SelectAttribute should also reset postValue in setChoices

In SelectAttribute::setChoices, we check that $this->value is in the list of authorized choices, but we do not check $this->postValue. This causes problems in the edgecase where setChoices is called in-between readPostValue and applyPostValue, leaving the field with a invalid value despite the call to setChoices.

It is a problem for CSV import template selection field.

changed milestone to %FusionDirectory 1.4

added PJ1801-0146 label

marked this issue as related to fd-plugins#6083 (closed)

By Côme Chilliet on 2020-12-17T15:10:17 (imported from GitLab)

created merge request !847 to address this issue

By Côme Chilliet on 2020-12-17T15:10:27 (imported from GitLab)

mentioned in merge request !847

By Côme Chilliet on 2020-12-17T15:10:28 (imported from GitLab)

mentioned in commit fb58fb5f

By Côme Chilliet on 2020-12-17T15:11:39 (imported from GitLab)

added fusiondirectory-core label

added 1h of time spent at 2020-12-17

By Côme Chilliet on 2020-12-17T15:28:38 (imported from GitLab)

added To Be Tested label

changed title from SelectAttribute should also reset postValue is setChoices to SelectAttribute should also reset postValue in setChoices

By Côme Chilliet on 2021-01-05T10:49:40 (imported from GitLab)

Issue closed because linked issue is closed

By Jonathan Swaelens on 2021-01-28T09:19:32 (imported from GitLab)

closed

removed To Be Tested label

added simple-plugin label

added Fixed label