Merge branch '5956-use-strict-typing' into '1.4-dev'

Resolve "Use strict typing"

See merge request fusiondirectory/fd!535

include/class_SnapshotDialogs.inc

@@ -116,6 +116,7 @@ class SnapshotCreateDialog extends simplePlugin
   function save (): array
   {
     $this->parent->createSnapshot($this->object_dn, $this->description);
+    return array();
   }
 }
 

[bmortier]

SonarQube analysis indicates that quality gate is failed.

• Security Rating on New Code is passed: Actual value 1
• Reliability Rating on New Code is failed: Actual value 3 > 1
• Maintainability Rating on New Code is passed: Actual value 1
• Duplicated Lines on New Code (%) is passed: Actual value 3.1150159744408947

SonarQube analysis reported no issues.

By Ghost User on 2019-02-20T16:04:04 (imported from GitLab)