Merge branch '5956-use-strict-typing' into '1.4-dev'

Resolve "Use strict typing"

See merge request fusiondirectory/fd!534

setup/class_setupStepConfig.inc

 <?php
 /*
   This code is part of FusionDirectory (http://www.fusiondirectory.org/)
+
   Copyright (C) 2007 Fabian Hickert
-  Copyright (C) 2011-2016  FusionDirectory
+  Copyright (C) 2011-2019  FusionDirectory
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -166,19 +167,19 @@ class setupStepConfig extends configInLdap
   {
     return TRUE;
   }
-  function acl_is_createable ($base = ""): bool
+  function acl_is_createable (string $base = NULL): bool
   {
     return TRUE;
   }
-  function acl_is_removeable ($base = ""): bool
+  function acl_is_removeable (string $base = NULL): bool
   {
     return TRUE;
   }
-  function acl_is_moveable ($base = ""): bool
+  function acl_is_moveable (string $base = NULL): bool
   {
     return TRUE;
   }
-  function aclGetPermissions ($attribute = '0', $base = NULL, $skipWrite = FALSE): string
+  function aclGetPermissions ($attribute = '0', string $base = NULL, bool $skipWrite = FALSE): string
   {
     return 'cmdrw';
   }
@@ -189,4 +190,3 @@ class setupStepConfig extends configInLdap
     return configInLdap::isAccount($attrs);
   }
 }
-?>

[bmortier]

SonarQube analysis indicates that quality gate is failed.

• Security Rating on New Code is passed: Actual value 1
• Reliability Rating on New Code is failed: Actual value 3 > 1
• Maintainability Rating on New Code is passed: Actual value 1
• Duplicated Lines on New Code (%) is passed: Actual value 3.115638106650689

SonarQube analysis reported no issues.

By Ghost User on 2019-02-20T11:34:54 (imported from GitLab)