Commit 0e23503b authored by Benoit Mortier's avatar Benoit Mortier
Browse files

Cleaning minor sonar code compliance

Move this trailing comment on the previous empty line

Signed-off-by: default avatarBenoit Mortier <benoit.mortier@opensides.be>
Showing with 18 additions and 9 deletions
+18 -9
...@@ -89,7 +89,8 @@ class ldapFilter ...@@ -89,7 +89,8 @@ class ldapFilter
if (in_array($filter[0], ldapFilter::$operators)) { if (in_array($filter[0], ldapFilter::$operators)) {
$subfilters = array(); $subfilters = array();
$filter .= ')'; // We need an ending parenthesis in order to catch last subpart correctly /* We need an ending parenthesis in order to catch last subpart correctly */
$filter .= ')';
$offset = 0; $offset = 0;
$level = 0; $level = 0;
$open; $open;
......
...@@ -1576,7 +1576,8 @@ class listing ...@@ -1576,7 +1576,8 @@ class listing
foreach ($types as $type) { foreach ($types as $type) {
$i = objects::infos($type); $i = objects::infos($type);
$filter .= $i['filter']; $filter .= $i['filter'];
$attrs[] = $i['mainAttr']; // Specific key for departement objectTypes // Specific key for departement objectTypes
$attrs[] = $i['mainAttr'];
} }
$filter .= ")"; $filter .= ")";
$res = get_list($filter, $this->categories, $this->base, $attrs, GL_NONE); $res = get_list($filter, $this->categories, $this->base, $attrs, GL_NONE);
......
...@@ -134,7 +134,8 @@ class logging { ...@@ -134,7 +134,8 @@ class logging {
{ {
global $config; global $config;
if ($entry['objecttype'] == 'plugin/auditEvent') { if ($entry['objecttype'] == 'plugin/auditEvent') {
return; // Avoid infinite loop // Avoid infinite loop
return;
} }
$tabObject = objects::create('auditEvent'); $tabObject = objects::create('auditEvent');
$baseObject = $tabObject->getBaseObject(); $baseObject = $tabObject->getBaseObject();
......
...@@ -37,7 +37,8 @@ class management ...@@ -37,7 +37,8 @@ class management
public $plHeadline = "unconfigured"; public $plHeadline = "unconfigured";
// The currently used object(s) (e.g. in edit, removal) // The currently used object(s) (e.g. in edit, removal)
public $dn = ""; // this is public due to some compatibility problems with class plugin.. // this is public due to some compatibility problems with class plugin..
public $dn = "";
protected $dns = array(); protected $dns = array();
// The last used object(s). // The last used object(s).
...@@ -48,11 +49,16 @@ class management ...@@ -48,11 +49,16 @@ class management
protected $storagePoints = array(); protected $storagePoints = array();
// The tab definitions to use for the current object. // The tab definitions to use for the current object.
protected $tabClass = ""; // e.g. usertabs // e.g. usertabs
protected $tabType = ""; // e.g. USERTABS protected $tabClass = "";
protected $aclPlugin = ""; // e.g. generic // e.g. USERTABS
protected $aclCategory = ""; // e.g. user protected $tabType = "";
protected $objectName = ""; // e.g. users // e.g. generic
protected $aclPlugin = "";
// e.g. user
protected $aclCategory = "";
// e.g. users
protected $objectName = "";
// The opened object. // The opened object.
protected $tabObject = NULL; protected $tabObject = NULL;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment