From 0e23503b0c40305171427f0faf32e6b454dc5d6e Mon Sep 17 00:00:00 2001
From: Benoit Mortier <benoit.mortier@opensides.be>
Date: Mon, 7 Nov 2016 19:51:49 +0100
Subject: [PATCH] Cleaning minor sonar code compliance Move this trailing
comment on the previous empty line
Signed-off-by: Benoit Mortier <benoit.mortier@opensides.be>
---
include/class_ldapFilter.inc | 3 ++-
include/class_listing.inc | 3 ++-
include/class_logging.inc | 3 ++-
include/class_management.inc | 18 ++++++++++++------
4 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/include/class_ldapFilter.inc b/include/class_ldapFilter.inc
index 318413b37..7169f08ae 100644
--- a/include/class_ldapFilter.inc
+++ b/include/class_ldapFilter.inc
@@ -89,7 +89,8 @@ class ldapFilter
if (in_array($filter[0], ldapFilter::$operators)) {
$subfilters = array();
- $filter .= ')'; // We need an ending parenthesis in order to catch last subpart correctly
+ /* We need an ending parenthesis in order to catch last subpart correctly */
+ $filter .= ')';
$offset = 0;
$level = 0;
$open;
diff --git a/include/class_listing.inc b/include/class_listing.inc
index 71d46c525..7dcc85c4e 100644
--- a/include/class_listing.inc
+++ b/include/class_listing.inc
@@ -1576,7 +1576,8 @@ class listing
foreach ($types as $type) {
$i = objects::infos($type);
$filter .= $i['filter'];
- $attrs[] = $i['mainAttr']; // Specific key for departement objectTypes
+ // Specific key for departement objectTypes
+ $attrs[] = $i['mainAttr'];
}
$filter .= ")";
$res = get_list($filter, $this->categories, $this->base, $attrs, GL_NONE);
diff --git a/include/class_logging.inc b/include/class_logging.inc
index 1656b9ea7..fb6e0e8ca 100644
--- a/include/class_logging.inc
+++ b/include/class_logging.inc
@@ -134,7 +134,8 @@ class logging {
{
global $config;
if ($entry['objecttype'] == 'plugin/auditEvent') {
- return; // Avoid infinite loop
+ // Avoid infinite loop
+ return;
}
$tabObject = objects::create('auditEvent');
$baseObject = $tabObject->getBaseObject();
diff --git a/include/class_management.inc b/include/class_management.inc
index 2c68b4825..f7dbd8340 100644
--- a/include/class_management.inc
+++ b/include/class_management.inc
@@ -37,7 +37,8 @@ class management
public $plHeadline = "unconfigured";
// The currently used object(s) (e.g. in edit, removal)
- public $dn = ""; // this is public due to some compatibility problems with class plugin..
+ // this is public due to some compatibility problems with class plugin..
+ public $dn = "";
protected $dns = array();
// The last used object(s).
@@ -48,11 +49,16 @@ class management
protected $storagePoints = array();
// The tab definitions to use for the current object.
- protected $tabClass = ""; // e.g. usertabs
- protected $tabType = ""; // e.g. USERTABS
- protected $aclPlugin = ""; // e.g. generic
- protected $aclCategory = ""; // e.g. user
- protected $objectName = ""; // e.g. users
+ // e.g. usertabs
+ protected $tabClass = "";
+ // e.g. USERTABS
+ protected $tabType = "";
+ // e.g. generic
+ protected $aclPlugin = "";
+ // e.g. user
+ protected $aclCategory = "";
+ // e.g. users
+ protected $objectName = "";
// The opened object.
protected $tabObject = NULL;
--
GitLab