User creation is performed even though an error is thrown within Posix

Description

A bug was found during a creation of a User with Posix, if UID/GID are forced (via template E.g) and you press save without configuring IDs. Error message will be seen but user will be created nonetheless and you cannot change IDs directly. An exit of the user creation page is required to configure the IDs afterwards.

Distribution Name and Version

Debian GNU/Linux 11 (bullseye)

FusionDirectory Version

Plugin with the defect

Posix / User (fd-core).

PHP version used

7.4.25

Origin of php packages

Distribution

Steps to Reproduce

1. Create a User
2. Activate Unix Tab
3. Force User/Group ID
4. Leave IDs blank (null)
5. Click apply after having fulfilled required fields within User tab.
6. Accept errors messages.
7. Put the IDs "forgotten"
8. Error message is seen saying User Login already exist. (No update performed).

Expected behavior:

An update of the user posix information.

Actual behavior:

No update is done, posix tab is closed, user is created without unix attributes.

Reproduces how often:

100% of the time.

changed milestone to %FusionDirectory 1.4

assigned to @tdockx

added plugin-posix label

changed due date to February 28, 2022

added PJ1802-0188 label

marked this issue as related to #6156 (closed)

created branch 6158-user-creation-is-performed-even-though-an-error-is-thrown-within-posix to address this issue

created branch 6158-user-creation-is-performed-even-though-an-error-is-thrown-within-posix-2 to address this issue

This issue seems linked to one already open: https://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6063

I linked both issues. The fix to implement requires a bigger re-worked of the save logic currently used. I propose to change the milestone of this towards FusionDirectory 1.5

added 2h of time spent

changed milestone to %FusionDirectory 1.5

removed due date

marked this issue as related to fd#6063

changed milestone to %FusionDirectory 1.6