Not possible to set host trustmode to another value of disabled in a template

Description

Not possible to set host trustmode to another value of disabled in a template

Distribution Name and Version

Ubuntu 18.04

FusionDirectory Version

1.4

Plugin with the defect

posix

PHP version used

7.3.33

Origin of php packages

ppa ondrej

Steps to Reproduce

1. Create an user template and change host trust mode to something else than disabled (in tab unix)
2. Save the template
3. Edit the template and the trust mode is set back to disabled

Expected behavior:

Keeping the value that we defined and be able to use it in web service later

Actual behavior:

It looks like the value is not saved

Reproduces how often: 100%

added PJ1808-0220 interns plugin-posix labels

assigned to @bmortier

assigned to @tdockx and unassigned @bmortier

changed milestone to %FusionDirectory 1.4

Hello @bmortier, @jswaelens, I have a doubt about this ticket. Not entirely sure if the described behavior was not intended for security.

It might be an easy fix by modifying below conditions :

    if ((count($this->host) == 1) && ($this->host[0] == '*')) {
      $this->trustMode = 'fullaccess';
    } elseif (count($this->host) > 0) {
      $this->trustMode = 'byhost';
    }

To be further tested

but

In summary: If you select in system trust (Picture below) "allow access to these hosts" (with at least one item) or full-access (automatic * ), it does work. Only %askme% and "allow access to thoses hosts" (without at lease one item) does not work.

added 1h of time spent

After team discussion, the "Trust mode" option must be "memorized" within the template. (With or without any items listed)

The option %askme% will be fix within another ticket.

added 5m of time spent

changed due date to February 22, 2022

Problem needs to be fixed as well in User posix and Group posix. Behavior is the same.

Something to look at (Screenshot below), it seems some new "SelectAttribute" object create an ldap entry (within fdTemplate) properly, others not. To be investigated. Below "SelectAttributes" :

1. (test) supannCivilite - working ("Mme" is set)
2. trustMode - not working (No values set).

(FIX) EDIT : $this->attributesAccess['trustMode']->setInLdap(FALSE); was setup, changing to TRUE resolved it. Although : $this->attributesAccess['force_id']->setInLdap(FALSE); is setup to FALSE but force_id is present within ldap fdTemplate.

added 4h of time spent

closed via commit 3ba0b2bf

Problem resolved for posixAccount as well as posixGroup templates. Fixed User creation and Unix Group with %askme% .

Although a uniformization of the management of attributes managed within ldap (fdTemplate) would be great. I will open a minor enhancement ticket for us.

A bug was found during creation of User with posix, if UID/GID are forced (via template E.g) and you press save without configuring IDs. Error message will be seen but user will be created nonetheless and you cannot change IDs directly. An exit of the user creation page is required to configure the IDs afterwards.

added 7h of time spent

marked this issue as related to #6158