domain mail add twice when edit the RENATER partage parameters

Description

In Renater Partage plugin associated to sympa plugin , When a entry is edited I gopt an ERROR 500 when FD trying to make modification trough the web service

Distribution Name and Version

on debian stretch

FusionDirectory Version

ii  fusiondirectory-plugin-renater-partage        1.2-2~jenkinsbuild799                        all          Renater partage integration plugin for FusionDirectory
ii  fusiondirectory-plugin-renater-partage-schema 1.2-2~jenkinsbuild799                        all          LDAP schema for FusionDirectory renater partage plugin

Plugin with the defect

plugin-renater-partage

PHP version used

Origin of php packages

apt-cache policy php
php:
  Installé : 1:7.0+49
  Candidat : 1:7.0+49
 Table de version :
 *** 1:7.0+49 500
        500 http://ftp.fr.debian.org/debian stretch/main amd64 Packages
        100 /var/lib/dpkg/status

Steps to Reproduce

I Try to add Partage information applied to a list

Expected behavior:

PD should create or modified a group on Partage side

Actual behavior: Error when trying top make some modification due to a incorrect partage account , FD add Partage domain name even if "cn" field contain a domain name

It's a side effect of #5804 (closed)

assigned to @MCMic

hello,

so @MCMic #5804 (closed) should be reverted from 1.2-fixes because this seems to have some ramification inside the code not suited for a fix release

Cheers

@gallak You say you have an error 500 but your first screenshot shows an LDAP error? Do you still get this LDAP error? When doing what?

fdRenaterPartageGroupMailStatus is in the schema and in both group and sympa alias renaterPartage object classes so it should be fine.

mentioned in issue #5804 (closed)

Well don't take care of the first screen shoot because there are a lot of chance that an human (me) issue when I import data with LDIF ..

the main error is the error 500 on the second screenshot ( you have the reason on the background) : name=dsi.lyon%40irstea.fr%40irstea.fr&displayname=etc ... name is the main identifier on Partage so the domain name MUST match to the partage profile. if it doesn't an 500 error appears ( currently Partage domain is irstea.fr not irstea.fr@irstea.fr In my case it should be name=dsi.lyon%40irstea.fr&displayname=etc...

The main problem with sympa is that LDAP entry used for aliases management could be different . It depend of mail architecture ... so SYMPA is flexible, LDAP alias sould be flexible, and FD partage should flexible too.

Is it possible to do the following : allow '@' in cn (related to sympa plugin) add a condition (related to partage plugin) like : IF cn don't contain "@" DO append Partage domain domain when ttalking to partage server

If administrator create ldap aliases trough sympa template, we assume that they know what there are doing

changed milestone to %FusionDirectory 1.3

added plugin-renater-partage label

added PJ1802-0188 label

created branch 5807-domain-mail-add-twice-when-edit-the-renater-partage-parameters

mentioned in commit 02874c86

added 30m of time spent at 2018-04-18

added To Be Tested plugin-sympa labels

can't verify it, while #5848 (closed) isn't solved

added PJ1807-0216 label

removed PJ1802-0188 label

please revert this piece of code , this issue is a duplicate of #5848 (closed) you can close #5807 (closed)

removed To Be Tested label

added To Be Tested label