Skip to content
GitLab
Unverified Commit ac29f690 authored by Côme Chilliet's avatar Côme Chilliet
Browse files

:ambulance: fix(schac) Do not fill schacPersonalUniqueCode automatically on templates 

issue #6093
parent 776a5cde
dev 6104-mail-methods-refactor 6231-give-the-ability-to-the-webservice-to-notice-if-an-attribute-is-monovalued-or-multivalued 6237-add-requiredattrs-array-to-the-webservice-informations 6245-adapt-the-ci-to-the-reorganisation-of-the-dev-tools-and-fixing-the-trigger-downstream-pipelines 6250-supann-configuration-backend-requires-account-life-cycle-section 6280-plugins-update-plugins-to-take-into-consideration-the-new-directory-of-core-structure 6310-tasks-reminder-error-in-the-schema-duplicate-attribute-id 6311-put-the-version-1-5-in-all-yaml-for-fusiondirectory-1-5 6322-template-issue-when-creating-a-template-with-empty-password-error-message-should-not-be-seen-2 6332-zimbra-allows-update-of-data-for-unknown-domain-name-for-specific-individual-aliases 6337-webservice-issue-with-archiving-post-request-not-responding-but-successfully-archiving-user 6341-supann-extract-resources-states-sub-states-from-backend-configuration-to-their-own-objects master fusiondirectory-1.5 fusiondirectory-1.4
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 12 additions and 10 deletions
+12 -10
schac/personal/schac/class_schacAccount.inc
+ 12
− 10
View file @ ac29f690
...@@ -59,18 +59,20 @@ class schacAccount extends simplePlugin ...@@ -59,18 +59,20 @@ class schacAccount extends simplePlugin
{ {
parent::update(); parent::update();
if (($supannTab = $this->parent->getTabOrServiceObject('supannAccount')) !== FALSE) { if (!$this->is_template) {
$ine = $supannTab->supannCodeINE; if (($supannTab = $this->parent->getTabOrServiceObject('supannAccount')) !== FALSE) {
  • sonar gitlab-ci @gitlab-ci-sonar ·
    Developer

    :warning: Merge this if statement with the enclosing one. :blue_book:

Please register or sign in to reply
$uniquecodes = $this->schacPersonalUniqueCode; $ine = $supannTab->supannCodeINE;
foreach ($uniquecodes as $key => $uniquecode) { $uniquecodes = $this->schacPersonalUniqueCode;
if (preg_match('/^urn:schac:personalUniqueCode:int:esi:fr:/', $uniquecode)) { foreach ($uniquecodes as $key => $uniquecode) {
unset($uniquecodes[$key]); if (preg_match('/^urn:schac:personalUniqueCode:int:esi:fr:/', $uniquecode)) {
unset($uniquecodes[$key]);
}
} }
if (!empty($ine)) {
$uniquecodes[] = 'urn:schac:personalUniqueCode:int:esi:fr:'.$ine;
}
$this->schacPersonalUniqueCode = array_values($uniquecodes);
} }
if (!empty($ine)) {
$uniquecodes[] = 'urn:schac:personalUniqueCode:int:esi:fr:'.$ine;
}
$this->schacPersonalUniqueCode = array_values($uniquecodes);
} }
return TRUE; return TRUE;
......
  • sonar gitlab-ci @gitlab-ci-sonar ·
    Developer

    SonarQube analysis reported 1 issue

    • :warning: 1 major

    Watch the comments in this conversation to review them.

Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment