fix(systems) Avoid PHP error and unclear error message if server has no mac address

issue #5748

fix(systems) Avoid PHP error and unclear error message if server has no mac address
issue #5748
69352c2f · Côme Chilliet · 9d362fc2 · 69352c2f
Commit 69352c2f authored 7 years ago by Côme Chilliet
Hide whitespace changes
Inline Side-by-side

Showing

with 7 additions and 0 deletions
+7 -0
--- a/systems/admin/systems/class_serverService.inc
+++ b/systems/admin/systems/class_serverService.inc
@@ -316,6 +316,13 @@ class ServerService extends simpleManagement
        );
      } else {
        $target = $this->parent->getBaseObject()->macAddress;
+        if (empty($target)) {
+          msg_dialog::display(
+            sprintf(_('Could not get execute action %s on service %s.'), $action, $service),
+            _('This server has no mac address.'), ERROR_DIALOG
+          );
+          return;
+        }
        if (is_array($target)) {
          $target = $target[0];
        }