class_plugin should be reviewed

The class plugin should be checked as there is some weird or unefficient code in there. Also, a lot of common plugin operations could be factorized in a super class (either this one or a subclass), including ACL stuff, handling of arrays and booleans, and so on.

(from redmine: issue id 946, created on 2012-05-21, closed on 2017-02-06)

• Relations:
  • relates #5318
  • copied_to #2586
  • copied_to #5139
• Changesets:
  • Revision 33b0a90d by Côme Chilliet on 2015-12-16T09:32:45.000Z:

Fixes #946 Removed useless stuff from plugin class now that everything is migrated to simplePlugin

• Revision 692b3833 by Côme Chilliet on 2015-12-16T09:37:53.000Z:

Fixes #946 Merged plugin::execute in simplePlugin::execute

• Revision de6fccfd by Côme Chilliet on 2015-12-17T08:52:15.000Z:

Fixes #946 Cleaned up CSN handling

• Revision 63ae6490 by Benoit MORTIER on 2016-01-02T13:35:05.000Z:

Fixes #946 Removed useless stuff from plugin class now that everything is migrated to simplePlugin

Removed mention that the plugin class is the base of all the plugin construction

Signed-off-by: Mortier Benoit <benoit.mortier@opensides.be>

• Revision 9b5c1013 by Côme Chilliet on 2016-05-12T07:23:05.000Z:

Fixes #946 Cleaned up CSN handling

Conflicts:
	include/class_plugin.inc

• Revision 9bf25982 by Côme Chilliet on 2016-05-12T07:31:05.000Z:

Fixes #946 Cleaned up CSN handling

• Revision c06dba17 by Côme Chilliet on 2016-08-23T13:46:59.000Z:

Fixes #946 Cleanup of plugin/simplePlugin, remove of some deprecated code

• Revision fe33c3af by Côme Chilliet on 2016-09-07T13:48:55.000Z:

Fixes #946 Big plugin cleanup and some documentation fixes

• Revision 33b8540b by Côme Chilliet on 2016-09-07T15:13:20.000Z:

Fixes #946 Moved all template related stuff to templateHandling. Cleaned names and documentation.

• Revision 33da6206 by Côme Chilliet on 2016-09-08T12:36:56.000Z:

Fixes #946 Fixed an error in plugin class

• Revision 15f162be by Côme Chilliet on 2016-09-08T12:42:03.000Z:

Fixes #946 Remvoved useless postCopyHook mechanism

• Revision adf20862 by Côme Chilliet on 2016-09-08T12:47:00.000Z:

Fixes #946 Removed useless allow_remove mechanism

• Revision 3f997e82 by Côme Chilliet on 2016-09-08T13:21:18.000Z:

Fixes #946 fixed an error in plugin because of templateHandling refactor

• Revision b0b5762a by Côme Chilliet on 2016-09-08T15:36:40.000Z:

Fixes #946 Moved some more code from plugin to simplePlugin

• Revision 2801f581 by Côme Chilliet on 2016-09-12T09:22:00.000Z:

Fixes #946 $attrs is back to public because serverService needs access

• Revision 55185697 by Côme Chilliet on 2016-09-13T09:57:08.000Z:

Fixes #946 Put back ldap_error mechanism

• Revision 892cd318 by Côme Chilliet on 2017-01-18T14:20:35.000Z:

Fixes #946 Moved dialog to simplePlugin and plNotify to simpleTabs

• Revision 21eddfc2 by Côme Chilliet on 2017-01-18T14:36:01.000Z:

Fixes #946 Moved is_account and get_allowed_bases to simplePlugin

• Revision 1a14e8f9 by Côme Chilliet on 2017-01-18T15:07:55.000Z:

Fixes #946 Merged move and rename methods, moved the result to simplePlugin

• Revision 057be10a by Côme Chilliet on 2017-01-18T16:00:45.000Z:

Fixes #946 Finished cleaning and merging plugin in simplePlugin

• Revision 11d074e0 by Côme Chilliet on 2017-01-19T08:58:57.000Z:

Fixes #946 Removed a forgotten occurence of plugin class name

• Revision 33362646 by Côme Chilliet on 2017-01-19T09:15:09.000Z:

Fixes #946 Avoid PHP errors about undefined keys in plNotify

• Revision 004e96f2 by Côme Chilliet on 2017-01-19T10:06:04.000Z:

Fixes #946 fixed an error in ACL checking

• Revision 0197df01 by Côme Chilliet on 2017-01-19T10:06:21.000Z:

Fixes #946 Removed an other occurence of plugin class

• Revision 3e6c0212 by Côme Chilliet on 2017-01-26T11:05:43.000Z:

Fixes #946 Fixed PHP errors in ogroups because of simpleTabs plNotify handling

• Custom Fields:
  • Bug in version: 1.0.18
• Uploads:
  • 0001-Fixes-946-class_plugin-should-be-reviewed.patch
  • 0002-Fixes-946-simpleAttribute.patch
  • 0003-Fixes-946-class_plugin-should-be-reviewed.patch
  • 0004-Fixes-946-class_plugin-should-be-reviewed.patch
  • 0005-Fixes-946-ArrayAttribute.patch

Hello, meet the simplePlugin class. Using an Attribute class which has a lot of subclasses, the idea is to be able to create simple plugins just by listing the LDAP fields and their options.

It is pretty limited right now, but I was already able to do a demo plugin with it, and before to continue the coding work I intend to document the code and the idea on the wiki.

(from redmine: written on 2012-05-25)

By Côme Chilliet on 2017-09-02T14:43:48 (imported from GitLab)

Some more comments into the code, better way of handling constructor.

(from redmine: written on 2012-05-25)

By Côme Chilliet on 2017-09-02T14:43:48 (imported from GitLab)

Some more doxygen comment and error testing.

(from redmine: written on 2012-05-25)

By Côme Chilliet on 2017-09-02T14:43:48 (imported from GitLab)

This one should be applied instead of the other ones. I had to do some git manipulation to go back and forth…

(from redmine: written on 2012-05-29)

By Côme Chilliet on 2017-09-02T14:43:48 (imported from GitLab)

Some improvement and bugfix

(from redmine: written on 2012-05-29)

By Côme Chilliet on 2017-09-02T14:43:49 (imported from GitLab)

Patch for fd-plugins that's first step toward implementing argonautClient plug-in through simplePlugin. Not working yet, I'm just posting it to not lose it

[EDIT] that's now in #991

(from redmine: written on 2012-05-29)

By Côme Chilliet on 2017-09-02T14:43:49 (imported from GitLab)

Some improvement in order to ease argonautClient implementation.

(from redmine: written on 2012-05-30)

By Côme Chilliet on 2017-09-02T14:43:49 (imported from GitLab)

This adds support for multi-valuated attributes, not tested yet.

(from redmine: written on 2012-05-31)

By Côme Chilliet on 2017-09-02T14:43:49 (imported from GitLab)

ArrayAttribute and SetAttribute are working for multi-valuated attributes.

(from redmine: written on 2012-06-01)

By Côme Chilliet on 2017-09-02T14:43:49 (imported from GitLab)

Hello,

as we have decided to go with simple plugin i think this bug can be closed no ?

Cheers

(from redmine: written on 2012-07-02)

By bmortier on 2017-09-02T14:43:50 (imported from GitLab)

No, plugin class still needs to be cleaned as simplePlugin is using it.

(from redmine: written on 2012-07-03)

By Côme Chilliet on 2017-09-02T14:43:50 (imported from GitLab)

Finally got rid of plugin class. Packages needs to be updated.

(from redmine: written on 2017-01-18)

By Côme Chilliet on 2017-09-02T14:43:50 (imported from GitLab)

Close issue

(from redmine: written on 2017-02-06)

By Côme Chilliet on 2017-09-02T14:43:50 (imported from GitLab)

closed

By Côme Chilliet on 2017-09-02T14:43:50 (imported from GitLab)

added Changed label

By bmortier on 2018-09-24T13:52:45 (imported from GitLab)

removed Bugs label

added PJ1802-0188 fusiondirectory-core labels