[Enhancement] - Change CI 1.3.1 - CodeStyle to refelect 1.4 rules
Requirements
- Filling out the template is required. Any Enhancement request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
- All new code requires tests to ensure against regressions
Descriptive title for this enhancement
1.3.1 uses an old codestyle and it has been agreed to change it to correspond to 1.4 (actual version to date).
Actual behavior
Old codestyle is being used
Expected behavior
New codestyle is being used
Step by step description of new behaviour
# PHP codesniffer
create_php_code_sniffer_rapport:
image: registry.fusiondirectory.org/fusiondirectory/fd/phpcodesniffer-cli:stretch
stage: codestyle
only:
- branches
script:
- test -d ../dev-tools/ && rm -Rf ../dev-tools/
- git clone --depth 1 https://gitlab.fusiondirectory.org/fusiondirectory/dev-tools.git -b 1.3 ../dev-tools
- find . -type f -name '*.php' -o -name '*.inc' > ./filelist
- phpcs --standard=../dev-tools/php-codesniffer-rules/FDStandard/ruleset.xml --file-list=./filelist
change the git clone with proper updated branch reflecting latest up to date branch.
Benefits
Code style will be aligned everywhere.
Possible Drawbacks
Possible risk of automated-testing reporting issues for mistakes introduced during code style changes. No php lint errors must be reported prior of changing the CI.
Applicable Issues
None