Attempting to remove array values from a multivaluated attribute through the webservice removes all values
Attempting to remove array values from a multivaluated attribute through the webservice removes all values
When using https://rest-api.fusiondirectory.info/#operation/deleteAttributeValues on a complex multivaluated attribute which uses arrays as values, such as dnsRecords, all values are removed.
This is because the code calls array_remove_entries which uses array_diff which only knows how to deal with stringable values. When called on arrays it trigger array to string conversion warnings.
So either we fix array_remove_entries to be able to work on arrays values, or we change the webservice code. In both cases we should make sure that array_remove_entries crashes out instead of returning an empty array to avoid data loss.
Activity
moved from fd-plugins#6113 (closed)
By Côme Chilliet on 2021-06-03T09:13:51 (imported from GitLab)
changed milestone to %FusionDirectory 1.4
added plugin-webservice label
added PJ2103-0403 label
mentioned in commit b0eaf9fc
By Côme Chilliet on 2021-06-03T09:40:29 (imported from GitLab)
mentioned in commit 96cb7bfa
By Côme Chilliet on 2021-06-03T09:42:38 (imported from GitLab)
mentioned in commit 5bd86dd6
By Côme Chilliet on 2021-06-03T10:14:36 (imported from GitLab)
added To Be Tested label
hello @cchilliet
to test is the bug is fixed can you provide the test that need to be performed
Cheers
By bmortier on 2021-08-02T19:49:47 (imported from GitLab)
Something like this:
# List records of a zone GET /objects/dnsZone/zoneName=test.com.,ou=dns,dc=example,dc=com/dnsZone/dnsRecords # Add a record PATCH /objects/dnsZone/zoneName=test.com.,ou=dns,dc=example,dc=com/dnsZone/dnsRecords/values [["www","aAAARecord","2606:2800:220:1:248:1893:25c8:1990","0.0.8.2.6.0.6.2.ip6.arpa."]] # Check that is was added GET /objects/dnsZone/zoneName=test.com.,ou=dns,dc=example,dc=com/dnsZone/dnsRecords # Delete it DELETE /objects/dnsZone/zoneName=test.com.,ou=dns,dc=example,dc=com/dnsZone/dnsRecords/values [["www","aAAARecord","2606:2800:220:1:248:1893:25c8:1990","0.0.8.2.6.0.6.2.ip6.arpa."]] # Check that is was removed GET /objects/dnsZone/zoneName=test.com.,ou=dns,dc=example,dc=com/dnsZone/dnsRecordsBy Côme Chilliet on 2021-08-03T07:33:35 (imported from GitLab)
