Add support in the ci for phpstan

Descriptive title for this enhancement

we need to add static code analysis to our ci with phpstan

Actual behavior

we only run php lint et code sniffer on our code actually

Expected behavior

find error by running code analysis on our code

Step by step description of new behaviour

1. copy the .neon file from https://gitlab.fusiondirectory.org/fusiondirectory/dev-tools/-/tree/master/phpstan/fusiondirectory/1.4-dev into the root of the core source
2. run phpstan -c phpstan.neon

Benefits

get static analysis of the code

Possible Drawbacks

none

Applicable Issues

changed due date to December 15, 2020

By bmortier on 2020-12-10T09:16:53 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

added gitlab-ci label

added PJ1802-0188 label

marked this issue as related to #6114

By bmortier on 2020-12-10T14:40:00 (imported from GitLab)

changed title from add support in the ci for phpstan to Add support in the ci for phpstan

By Côme Chilliet on 2021-05-27T10:06:32 (imported from GitLab)

created merge request !904 to address this issue

By Côme Chilliet on 2021-06-14T12:50:42 (imported from GitLab)

mentioned in merge request !904

By Côme Chilliet on 2021-06-14T12:50:43 (imported from GitLab)

mentioned in commit 9d95d515

By Côme Chilliet on 2021-06-14T12:57:19 (imported from GitLab)

mentioned in commit 1596c19a

By Côme Chilliet on 2021-06-14T13:00:19 (imported from GitLab)

mentioned in commit 7f6cc88b

By Côme Chilliet on 2021-06-14T13:02:31 (imported from GitLab)

mentioned in commit f297ca18

By Côme Chilliet on 2021-06-14T13:25:13 (imported from GitLab)

mentioned in commit 88901ba9

By Côme Chilliet on 2021-06-14T13:29:51 (imported from GitLab)

mentioned in commit fa324493

By Côme Chilliet on 2021-06-14T14:55:57 (imported from GitLab)

added 2h 30m of time spent

By Côme Chilliet on 2021-06-14T15:06:26 (imported from GitLab)

changed due date to June 17, 2021

By Côme Chilliet on 2021-06-14T15:06:38 (imported from GitLab)

mentioned in commit a40003f2

By Côme Chilliet on 2021-06-22T10:05:41 (imported from GitLab)

mentioned in commit 670e51de

By Côme Chilliet on 2021-07-08T06:58:56 (imported from GitLab)

marked this issue as related to docker/phpstan#1

By bmortier on 2021-07-22T08:33:03 (imported from GitLab)

@jswaelens Now the the docker image is done, we should integrate it in the codestyle section after the codesniffer check

Cheers

By bmortier on 2021-07-22T09:29:06 (imported from GitLab)

added 5m of time spent

By bmortier on 2021-07-22T09:29:06 (imported from GitLab)

created merge request !917 to address this issue

By Jonathan Swaelens on 2021-07-22T13:36:59 (imported from GitLab)

mentioned in merge request !917

By Jonathan Swaelens on 2021-07-22T13:37:01 (imported from GitLab)

added 2h 30m of time spent

By Jonathan Swaelens on 2021-07-22T19:08:11 (imported from GitLab)

added 1h of time spent

By Jonathan Swaelens on 2021-07-23T08:56:01 (imported from GitLab)

mentioned in commit 6263795b

By Côme Chilliet on 2021-07-29T07:46:46 (imported from GitLab)

mentioned in commit 73140d58

By Côme Chilliet on 2021-07-29T08:11:07 (imported from GitLab)

mentioned in commit 0a61ee89

By Côme Chilliet on 2021-07-29T08:17:23 (imported from GitLab)

added 1h of time spent

By Côme Chilliet on 2021-07-29T08:18:57 (imported from GitLab)

removed due date

By bmortier on 2021-07-29T14:47:34 (imported from GitLab)

cloned to fd-plugins#6134 (closed)

By bmortier on 2021-07-29T14:47:44 (imported from GitLab)

closed

marked this issue as related to fd-plugins#6134 (closed)

By bmortier on 2021-07-29T18:55:38 (imported from GitLab)

reopened

created merge request !920 to address this issue

By Côme Chilliet on 2021-08-02T15:10:36 (imported from GitLab)

mentioned in merge request !920

By Côme Chilliet on 2021-08-02T15:10:37 (imported from GitLab)

mentioned in commit 1614ba94

By Côme Chilliet on 2021-08-02T15:11:34 (imported from GitLab)

mentioned in commit eb9d3cdd

By Côme Chilliet on 2021-08-03T07:07:23 (imported from GitLab)

closed