Skip to content
GitLab
Closed
Issue created by bmortier@bmortierMaintainer

Search does not work on template

Closed

Search does not work on template

Description

Using the search field not work for templates (user)

Distribution Name and Version

Debian

FusionDirectory Version

1.4

PHP version used

php7

Origin of php packages

Debian

Steps to Reproduce

  1. Create a departement
  2. Create user template in the departement
  3. Try to search for the template with or without subtree it not appear

Expected behavior:

The template must be found

Actual behavior:

The template is not found

Reproduces how often: 100% reproduced on demo-dev

Edited

    Tasks

    0

    Activity

    • bmortier changed milestone to %FusionDirectory 1.4

      changed milestone to %FusionDirectory 1.4

      By Jonathan Swaelens on 2020-08-04T13:00:03 (imported from GitLab)

    • bmortier added PJ1802-0188 label

      added PJ1802-0188 label

    • bmortier changed title from Search not work on tempate to Search does not work on tempate

      changed title from Search not work on tempate to Search does not work on tempate

      By bmortier on 2020-08-06T15:14:59 (imported from GitLab)

    • bmortier changed title from Search does not work on tempate to Search does not work on template

      changed title from Search does not work on tempate to Search does not work on template

      By bmortier on 2020-08-06T15:15:19 (imported from GitLab)

    • bmortier added fusiondirectory-core label

      added fusiondirectory-core label

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      This is because fdTemplateField has no SUBSTR matching rule. It’s not easy to add one because this field might contain non-textual data. What were you trying to search for?

      A case which is not related to the schema but to current code is that search does not search in template cn, this could be fixed as a first improvement.

      By Côme Chilliet on 2020-08-19T15:16:48 (imported from GitLab)

    • bmortier added 1h of time spent at 2020-08-19

      added 1h of time spent at 2020-08-19

      By Côme Chilliet on 2020-08-19T15:16:48 (imported from GitLab)

    • bmortier changed due date to August 24, 2020

      changed due date to August 24, 2020

      By Côme Chilliet on 2020-08-19T15:20:56 (imported from GitLab)

    • bmortier changed due date to August 25, 2020

      changed due date to August 25, 2020

      By Côme Chilliet on 2020-08-19T15:21:04 (imported from GitLab)

    • bmortier created merge request !797 to address this issue

      created merge request !797 to address this issue

      By Côme Chilliet on 2020-08-20T08:55:14 (imported from GitLab)

    • bmortier mentioned in merge request !797

      mentioned in merge request !797

      By Côme Chilliet on 2020-08-20T08:55:15 (imported from GitLab)

    • bmortier mentioned in commit 60cc3eb2

      mentioned in commit 60cc3eb2

      By Côme Chilliet on 2020-08-20T08:57:01 (imported from GitLab)

    • bmortier mentioned in commit 38a4cd7b

      mentioned in commit 38a4cd7b

      By Côme Chilliet on 2020-08-20T09:27:44 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      A schema update on template-fd.schema is needed.

      Both problems should be fixed (search in templated fields and search in template cn)

      By Côme Chilliet on 2020-08-20T09:41:24 (imported from GitLab)

    • bmortier added 2h 30m of time spent at 2020-08-20

      added 2h 30m of time spent at 2020-08-20

      By Côme Chilliet on 2020-08-20T09:41:45 (imported from GitLab)

    • bmortier added To Be Tested label

      added To Be Tested label

    • bmortier added release notes label

      added release notes label

      • bmortier
        bmortier @bmortier ·
        Author Maintainer

        This broke tests, but it is because it uncovered pre-existing errors in LDAP filter syntax which are now detected, so I’d say that’s a good thing. I will attempt to fix those.

        By Côme Chilliet on 2020-08-25T08:34:43 (imported from GitLab)

      • bmortier
        bmortier @bmortier ·
        Author Maintainer

        I fixed some of those, but it appears that (attribute=) is not actually invalid, it just always evaluate to false (at least in openldap). So I will fix ldapFilter parsing to accept such a syntax.

        By Côme Chilliet on 2020-08-25T08:34:43 (imported from GitLab)

      • bmortier
        bmortier @bmortier ·
        Author Maintainer

        The exact explanation:

        <hyc> it's valid for attributes whose syntax allows zero-length values

        I have no idea which syntax that is, I never saw a zero-length value in LDAP, though it would be handy.

        By Côme Chilliet on 2020-08-26T12:07:15 (imported from GitLab)

        Edited by bmortier
      • Please register or sign in to reply
    • bmortier mentioned in issue fd-plugins#6067 (closed)

      mentioned in issue fd-plugins#6067 (closed)

      By Côme Chilliet on 2020-08-25T07:58:18 (imported from GitLab)

    • bmortier created merge request !801 to address this issue

      created merge request !801 to address this issue

      By Côme Chilliet on 2020-08-25T08:34:52 (imported from GitLab)

    • bmortier mentioned in merge request !801

      mentioned in merge request !801

      By Côme Chilliet on 2020-08-25T08:34:54 (imported from GitLab)

    • bmortier mentioned in commit 44ad2885

      mentioned in commit 44ad2885

      By Côme Chilliet on 2020-08-25T08:43:51 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Fixed the filter parsing problem, should be good now.

      By Côme Chilliet on 2020-08-25T10:21:53 (imported from GitLab)

    • bmortier added 2h of time spent at 2020-08-25

      added 2h of time spent at 2020-08-25

      By Côme Chilliet on 2020-08-25T10:21:53 (imported from GitLab)

    • bmortier assigned to @jswaelens and unassigned @cchilliet

      assigned to @jswaelens and unassigned @cchilliet

      By Côme Chilliet on 2020-08-25T10:21:53 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Tested on demo-dev buster with all plugins and is working properly I can now find the template objects

      By Jonathan Swaelens on 2020-12-02T10:30:08 (imported from GitLab)

    • bmortier closed

      closed

    • bmortier added 10m of time spent at 2020-12-02

      added 10m of time spent at 2020-12-02

      By Jonathan Swaelens on 2020-12-02T10:30:10 (imported from GitLab)

    • bmortier removed due date

      removed due date

      By Jonathan Swaelens on 2020-12-02T10:30:10 (imported from GitLab)

    • bmortier added Fixed label and removed To Be Tested label

      added Fixed label and removed To Be Tested label

    Please register or sign in to reply