Add option ldif-wrap=no in class_ldap.inc

Descriptive title for this enhancement

Add option ldif-wrap=no in class_ldap.inc

Actual behavior

Actually ldapsearch is performed without the option

Expected behavior

It would be nice to add the option or having a way to activate the option

Step by step description of new behaviour

1. Edit class_ldap.inc
2. Add ldif-wrap=no in the cmd

# before
$cmd = 'ldapsearch'.($this->tls ? ' -ZZ' : '')." -x -LLLL -D {$admin} {$filter} {$limit} {$scope} -H {$host} -b {$dn} -w {$pwd} ";
# after
$cmd = 'ldapsearch'.($this->tls ? ' -ZZ' : '')." -o ldif-wrap=no -x -LLLL -D {$admin} {$filter} {$limit} {$scope} -H {$host} -b {$dn} -w {$pwd} ";

Benefits

The ldif will no more contain wrap it can ease replace operation because we not need to think that the line can be split

Possible Drawbacks

None

changed milestone to %FusionDirectory 1.4

By Jonathan Swaelens on 2020-07-28T13:33:53 (imported from GitLab)

added PJ1802-0188 label

added fusiondirectory-core label

It seems for our internal use it’s not important if wrapping is on or off, we only use ldif generation for snapshots and those are recompressed anyway.

So, the only use for this will be ldapmanager LDIF export, should I add a checkbox for activating wrapping or not in this case? What should the default be? (no wrapping will generate really long lines for values such as JPEG images)

By Côme Chilliet on 2020-08-25T10:19:53 (imported from GitLab)

added 20m of time spent at 2020-08-25

By Côme Chilliet on 2020-08-25T10:19:54 (imported from GitLab)

created merge request !803 to address this issue

By Côme Chilliet on 2020-08-26T12:40:40 (imported from GitLab)

mentioned in merge request !803

By Côme Chilliet on 2020-08-26T12:40:41 (imported from GitLab)

mentioned in issue fd-plugins#6069 (closed)

By Côme Chilliet on 2020-08-26T12:53:55 (imported from GitLab)

mentioned in commit 2740606b

By Côme Chilliet on 2020-08-26T12:55:50 (imported from GitLab)

Can be closed when fd-plugins#6069 (closed) is.

By Côme Chilliet on 2020-08-26T13:18:34 (imported from GitLab)

added To Be Tested label

Closing because fd-plugins#6069 (closed) is closed

By Jonathan Swaelens on 2021-01-28T10:26:19 (imported from GitLab)

closed

added 5m of time spent at 2021-01-28

By Jonathan Swaelens on 2021-01-28T10:26:20 (imported from GitLab)

removed To Be Tested label

added Added label