Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory fusiondirectory
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectoryfusiondirectory
  • Issues
  • #6099
Closed
Open
Issue created May 26, 2020 by bmortier@bmortierMaintainer

$displayHeader is protected but accessed from outside

While reviewing fd-plugins#6053 (closed), I noticed that $displayHeader is declared protected in simplePlugin but public (using ugly keyword var) in most plugin classes.

And it is accessed from outside, sometimes from simplePlugin classes which should work, but also from rest.php which is gonna be a problem.

It is always accessed to test if tab is active, so we should just add an isActive method and use this.

Edited May 26, 2020 by bmortier
Assignee
Assign to
Time tracking