Logout in cas mode make a redirection error

Description

When we click on logout in CAS we are not forwark to the cas portail again

Distribution Name and Version

Debian Buster

FusionDirectory Version

1.4

PHP version used

7

Origin of php packages

Debian repo

Steps to Reproduce

1. Enable CAS
2. Connect with CAS
3. Logout through CAS
4. The URL look like "http://fd.example.com/index.php?signout=1&ticket=ST-6fd6710d15749e5d7f51e9813043d718" but the browser said it's miss redirect

Maybe https://apereo.github.io/cas/4.2.x/installation/Logout-Single-Signout.html can help.

Expected behavior:

Redirect on CAS portail URL (auth.example.com in my case)

Actual behavior:

Redirect error by the browser

Reproduces how often: 100%

changed milestone to %FusionDirectory 1.4

By Jonathan Swaelens on 2020-04-21T19:15:28 (imported from GitLab)

added PJ1906-0279 label

assigned to @bmortier and unassigned @MCMic

By bmortier on 2020-05-05T07:28:04 (imported from GitLab)

added fusiondirectory-core label

added insa lyon label

assigned to @cchilliet and unassigned @bmortier

By bmortier on 2020-10-14T07:23:11 (imported from GitLab)

@jswaelens What is the exact error you get?

By Côme Chilliet on 2020-10-15T08:02:32 (imported from GitLab)

hello @cchilliet,

i just linked the ticket from insa with the full trace

Cheers

By bmortier on 2020-10-15T08:02:32 (imported from GitLab)

added 10m of time spent at 2020-10-15

By Côme Chilliet on 2020-10-15T08:00:52 (imported from GitLab)

added Need Info label

added 1h of time spent at 2020-10-15

By Côme Chilliet on 2020-10-15T14:25:19 (imported from GitLab)

created merge request !875 to address this issue

By Côme Chilliet on 2021-03-05T14:56:22 (imported from GitLab)

mentioned in merge request !875

By Côme Chilliet on 2021-03-05T14:56:23 (imported from GitLab)

mentioned in commit d4a9ca30

By Côme Chilliet on 2021-03-05T15:20:28 (imported from GitLab)

Should be fixed now, the code in index.php needed to be adapted to a change in FusionDirectory configuration.

By Côme Chilliet on 2021-03-05T15:37:44 (imported from GitLab)

added To Be Tested label

removed Need Info label

added telecom sud paris label

Logout is still broken in case of automatic logout when session expires.

Reason:

• In main.php we destroy the session and redirect to index.php?signout=1&message=expired
• In index.php because session is already gone we cannot check the configuration to see that CAS is used, so phpCAS::logout() is not called.
• Login method ask CAS to log in, and give as redirection URL index.php?signout=1&message=expired
• CAS log in and redirect to index.php which destroys session and loops

By Côme Chilliet on 2021-05-04T07:58:35 (imported from GitLab)

The expected behavior would be to indeed trigger a CAS login, but with the correct redirection URL to avoid a second logout.

By Côme Chilliet on 2021-05-04T07:58:35 (imported from GitLab)

Should be good now.

By Côme Chilliet on 2021-05-04T10:31:43 (imported from GitLab)