Fatal error when applying template with no asked fields

Description

Fatal error: Uncaught TypeError: Argument 2 passed to simplePlugin::adapt_from_template() must be of the type array, null given, called in /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc on line 465 and defined in /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:1923 
Stack trace: 
#0 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(465): simplePlugin->adapt_from_template(Array, NULL) 
#1 /usr/share/fusiondirectory/include/class_template.inc(355): simpleTabs->adapt_from_template(Array, NULL) 
#2 /usr/share/fusiondirectory/include/management/class_templateDialog.inc(115): template->apply() 
#3 /usr/share/fusiondirectory/include/management/class_templateDialog.inc(62): templateDialog->handle_finish() 
#4 /usr/share/fusiondirectory/include/management/class_management.inc(459): templateDialog->save_object() 
#5 /usr/share/fusiondirectory/include/management/class_management.inc(1274): management->execute() 
#6 /usr/share/fusiondirectory/include/class_pluglist.inc(576): man in /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc on line 1923

occurs when I try to create a SupAnn structure by using a template.

Distribution Name and Version

Debian buster

FusionDirectory Version

root@annuaire:~# apt-cache policy fusiondirectory-plugin-supann
fusiondirectory-plugin-supann:
  Installé : 1.4-2~jenkinsbuild602
  Candidat : 1.4-2~jenkinsbuild602
 Table de version :
 *** 1.4-2~jenkinsbuild602 500
        500 https://integration.fusiondirectory.org/repos/development/debian/fusiondirectory-dev-14-stretch stretch/main amd64 Packages
        100 /var/lib/dpkg/status
     1.2.3-4+deb10u1 500
        500 http://deb.debian.org/debian buster/main amd64 Packages
root@annuaire:~# 

Plugin with the defect

supann

PHP version used

php:
  Installé : 2:7.3+69
  Candidat : 2:7.3+69
 Table de version :
 *** 2:7.3+69 500
        500 http://deb.debian.org/debian buster/main amd64 Packages
        100 /var/lib/dpkg/status

Origin of php packages

from debian

Steps to Reproduce

1. create a SupAnn template with %r|% in all mandatory fields
2. create a structure using this template

extract of template used

cn=TPL_SUPANN,ou=templates,ou=structures
objectClass: fdTemplate
fdTemplateField: facsimileTelephoneNumber:+%r[1,2,d]|% %r[1,1,d]|% %r[2,2,d]|% %r[2,2,d]|% %r[2,2,d]|% %r[2,2,d]|%
fdTemplateField: objectClass:organizationalUnit
fdTemplateField: objectClass:supannEntite
fdTemplateField: ou:CENTRE_%r[3,3,d]|%
fdTemplateField: postalAddress:%r[1,2,d]|% rue de %r[10,20,l]|%
fdTemplateField: supannCodeEntite:CTR_%r[3,3,d]|%
fdTemplateField: supannTypeEntite:{SUPANN}S238
fdTemplateField: telephoneNumber:+%r[1,2,d]|% %r[1,1,d]|% %r[2,2,d]|% %r[2,2,d]|% %r[2,2,d]|% %r[2,2,d]|%
cn: TPL_SUPANN

Expected behavior:

a new supann structure is create base on template

Actual behavior:

Error !

Reproduces how often:

100%

changed milestone to %FusionDirectory 1.4

By agallavardin on 2020-03-06T10:12:24 (imported from GitLab)

assigned to @bmortier

By bmortier on 2020-03-06T10:12:25 (imported from GitLab)

error didn't occurs if at least one field contains %askme% macros.

I assumed that create a lot of random object isn't really useful.. maybe this kind of error could be catched.

By agallavardin on 2020-03-06T10:19:44 (imported from GitLab)

assigned to @MCMic and unassigned @bmortier

By bmortier on 2020-03-06T10:21:19 (imported from GitLab)

changed due date to March 10, 2020

By bmortier on 2020-03-06T10:21:27 (imported from GitLab)

added PJ1903-0263 label

added plugin-supann label

changed the description

By Côme Chilliet on 2020-03-10T09:06:13 (imported from GitLab)

changed due date to March 10, 2020

By Côme Chilliet on 2020-03-10T10:00:22 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2020-03-10T10:00:22 (imported from GitLab)

moved from fd-plugins#6035 (closed)

By Côme Chilliet on 2020-03-10T10:00:23 (imported from GitLab)

changed title from fatal error when apply template for supann entity to Fatal error when applying template with no asked fields

By Côme Chilliet on 2020-03-10T10:02:26 (imported from GitLab)

changed the description

By Côme Chilliet on 2020-03-10T10:02:26 (imported from GitLab)

Funnily enough, this would be fixed by upgrading to PHP 7.4 since array_merge will then accepts being called with no parameters.

For the record, the PHP error happening before the fatal error and which contains the real error is: array_merge() expects at least 1 parameter, 0 given, File:/usr/share/fusiondirectory/include/class_template.inc, Line: 355

By Côme Chilliet on 2020-03-10T10:05:17 (imported from GitLab)

mentioned in merge request !745

By Côme Chilliet on 2020-03-10T10:05:28 (imported from GitLab)

created merge request !745 to address this issue

By Côme Chilliet on 2020-03-10T10:05:28 (imported from GitLab)

mentioned in commit 5cb82a85

By Côme Chilliet on 2020-03-10T10:06:19 (imported from GitLab)

The MR should fix the fatal error, but we might want to improve the UI shown in this case, since if no fields are asked we get this:

I will try to make it so this screen is skipped and we get directly to the object edition.

By Côme Chilliet on 2020-03-10T10:10:13 (imported from GitLab)

mentioned in merge request !746

By Côme Chilliet on 2020-03-10T11:04:20 (imported from GitLab)

created merge request !746 to address this issue

By Côme Chilliet on 2020-03-10T11:04:20 (imported from GitLab)