Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory fusiondirectory
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectoryfusiondirectory
  • Issues
  • #6072
Closed
Open
Issue created Feb 18, 2020 by bmortier@bmortierMaintainer

Review dialog classes

We should add an interface for dialog classes that are passed to simplePlugin::openDialog, and document this and associated classes.

We should split execute and save_object as is done for other FusionDirectory classes.

Related to this is the problem of submitting form with enter: since 54220789 it submits a special hidden input called default_submit_hidden_button, but this is not correctly supported by dialogs which expects either add or cancel button to be pressed. We could map default_submit_hidden_button to add, but I’m afraid in some cases it may be active at the first dialog load? There is a PID system for management classes but only for them, maybe it would be useful to have one for other classes but I’m not convinced.

Assignee
Assign to
Time tracking