Review dialog classes

We should add an interface for dialog classes that are passed to simplePlugin::openDialog, and document this and associated classes.

We should split execute and save_object as is done for other FusionDirectory classes.

Related to this is the problem of submitting form with enter: since 54220789 it submits a special hidden input called default_submit_hidden_button, but this is not correctly supported by dialogs which expects either add or cancel button to be pressed. We could map default_submit_hidden_button to add, but I’m afraid in some cases it may be active at the first dialog load? There is a PID system for management classes but only for them, maybe it would be useful to have one for other classes but I’m not convinced.

There is also the class ManagementDialog for dialog used in management classes (management configuration and snapshot dialogs), which may serve as example? And may or may not use the same interface.

Management test stuff like method_exists($this->dialogObject, 'execute'), which should not be needed.

By Côme Chilliet on 2020-02-18T15:58:59 (imported from GitLab)

added 2h of time spent at 2020-02-18

By Côme Chilliet on 2020-02-18T15:59:04 (imported from GitLab)

mentioned in issue fd-plugins#6019 (closed)

By Côme Chilliet on 2020-02-20T08:19:28 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

By bmortier on 2020-03-21T14:24:58 (imported from GitLab)

added PJ1802-0188 fusiondirectory-core technical discussion labels

changed due date to March 31, 2020

By bmortier on 2020-03-21T14:25:51 (imported from GitLab)

removed due date

By Côme Chilliet on 2020-08-19T14:23:27 (imported from GitLab)

created merge request !805 to address this issue

By Côme Chilliet on 2020-08-27T09:17:43 (imported from GitLab)

mentioned in merge request !805

By Côme Chilliet on 2020-08-27T09:17:43 (imported from GitLab)

mentioned in commit 3e779346

By Côme Chilliet on 2020-08-27T14:21:48 (imported from GitLab)

mentioned in commit 3e14ee38

By Côme Chilliet on 2020-08-27T14:25:38 (imported from GitLab)

mentioned in commit 66d209df

By Côme Chilliet on 2020-08-27T14:30:53 (imported from GitLab)

This needs to be heavily tested before merging, also plugins will need to be adapted. I switched demo-custom to this branch so we can run core tests next week as a first step.

By Côme Chilliet on 2020-08-27T14:57:04 (imported from GitLab)

added 4h 30m of time spent at 2020-08-27

By Côme Chilliet on 2020-08-27T14:57:05 (imported from GitLab)

mentioned in commit 768bc2d0

By Côme Chilliet on 2020-09-01T10:15:24 (imported from GitLab)

mentioned in issue fd-plugins#6071 (closed)

By Côme Chilliet on 2020-09-01T10:19:24 (imported from GitLab)

mentioned in commit 607fb825

By Côme Chilliet on 2020-09-01T15:08:22 (imported from GitLab)

mentioned in commit 1ad539a9

By Côme Chilliet on 2020-09-03T08:46:58 (imported from GitLab)

mentioned in commit 28eadd85

By Côme Chilliet on 2020-09-03T08:50:08 (imported from GitLab)

mentioned in commit 32c3b172

By Côme Chilliet on 2020-09-03T09:50:11 (imported from GitLab)

mentioned in commit 47c6094d

By Côme Chilliet on 2020-09-03T10:07:43 (imported from GitLab)

mentioned in commit 4a209ad0

By Côme Chilliet on 2020-09-03T12:01:23 (imported from GitLab)

mentioned in commit 43f0da16

By Côme Chilliet on 2020-09-03T12:45:17 (imported from GitLab)

added 7h of time spent at 2020-09-03

By Côme Chilliet on 2020-09-03T15:59:19 (imported from GitLab)

mentioned in commit e914fec0

By Côme Chilliet on 2020-09-07T12:21:53 (imported from GitLab)

mentioned in commit 68c645d1

By Côme Chilliet on 2020-09-07T12:21:53 (imported from GitLab)

mentioned in commit e644e13d

By Côme Chilliet on 2020-09-07T12:21:54 (imported from GitLab)

mentioned in commit ec16f7f3

By Côme Chilliet on 2020-09-07T12:21:54 (imported from GitLab)

mentioned in commit a8c9bbf1

By Côme Chilliet on 2020-09-07T12:21:54 (imported from GitLab)

mentioned in commit 6155b1e2

By Côme Chilliet on 2020-09-07T12:21:55 (imported from GitLab)

mentioned in commit df5bca06

By Côme Chilliet on 2020-09-07T12:21:55 (imported from GitLab)

mentioned in commit cf618830

By Côme Chilliet on 2020-09-07T12:21:55 (imported from GitLab)

mentioned in commit 6aefbfaf

By Côme Chilliet on 2020-09-07T12:21:55 (imported from GitLab)

mentioned in commit 28f2ea84

By Côme Chilliet on 2020-09-07T12:21:55 (imported from GitLab)

mentioned in commit 07448d00

By Côme Chilliet on 2020-09-07T12:25:34 (imported from GitLab)

mentioned in commit 7659edad

By Côme Chilliet on 2020-09-07T14:49:42 (imported from GitLab)

mentioned in commit b7633546

By Côme Chilliet on 2020-09-07T15:00:57 (imported from GitLab)

added 3h of time spent at 2020-09-07

By Côme Chilliet on 2020-09-07T15:01:14 (imported from GitLab)

mentioned in commit 899b1e03

By Côme Chilliet on 2020-09-08T08:46:15 (imported from GitLab)

mentioned in commit 59c8af3b

By Côme Chilliet on 2020-09-08T09:50:52 (imported from GitLab)

mentioned in commit 52023004

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit 94eaa6ba

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit fa8bc04e

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit 9399f2d4

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit 48aa50a6

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit a369415a

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit 3940b53a

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit 992f56cb

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)

mentioned in commit 64c42656

By Côme Chilliet on 2020-09-08T09:50:54 (imported from GitLab)