Change the css of the alert box to be more in line with the breezy theme
Change the css of the alert box to be more in line with the breezy theme
Descriptive title for this enhancement
Change the css of the alert box to be more in line with the breezy theme
Actual behavior
When a error/info or other info pop the sytle is not in concordance with our breezy theme, we also have icons that are not pretty in those pop pup windows
Expected behavior
Have a nice user friendly stylistic pop up window
Step by step description of new behavior
The new style should still show the difference in meaningful way between error/warning/info, maybe change the icons or remove them.
Benefits
- more integrated
- more user friendly
Possible Drawbacks
Applicable Issues
Activity
added PJ1802-0188 enhancement labels
added plugin-public-forms label
@bmortier This would lose all info and get the user stuck.
What is the problem with the current error system? It’s the same one used in FD when editing information.
By Côme Chilliet on 2020-02-11T10:44:26 (imported from GitLab)
added technical discussion label
moved from fd-plugins#6028 (closed)
By Côme Chilliet on 2020-02-11T12:52:43 (imported from GitLab)
Several tries based on the look of the login window:
@bmortier What do you think?
The last one uses something closer to the previous look for the header as I find the font too big when using the login header font.
By Côme Chilliet on 2020-02-11T15:09:39 (imported from GitLab)
hello @MCMic,
to have a better overview we must first remove the red icon it think its to bulky. and the text inside maybe a little bigger
Cheers
By bmortier on 2020-02-11T15:15:06 (imported from GitLab)
Edited by bmortier@bmortier It’s the error icon from breezy theme, it comes from breeze: https://github.com/KDE/breeze-icons/blob/master/icons/status/64/dialog-error.svg
What would you like instead?
The text size is the same throughout FD except from titles. (there are smaller text size for copyright notice and stuff like that)
By Côme Chilliet on 2020-02-11T15:33:54 (imported from GitLab)
Here is how it’s used in a KDE error dialog:
(The width is fixed to it looks a bit weird)
Here’s with the icon next to the text header:
(The position it had was from login screen where FusionDirectory icon appear in the corner. I do not know if there are other pages with icons in FusionDirectory)By Côme Chilliet on 2020-02-11T15:52:09 (imported from GitLab)
@MCMic yes this version is much better, so only the icon and text will show you what is it about
ex: icon blue and text "Information"
Cheers
By bmortier on 2020-02-11T15:58:23 (imported from GitLab)
Edited by bmortier@bmortier I only moved the icon next to the title, apart from that which one you prefer for the first image? Do you think the title is too big or not?
I can make screenshots for info and warning dialogs as well.
By Côme Chilliet on 2020-02-11T16:22:37 (imported from GitLab)
@mcmic i prefer that last screenshot with the gray background https://gitlab.fusiondirectory.org/fusiondirectory/fd/issues/6069#note_74739.
all the dialog should look the same with only the icon and text telling what kind of info it is and the grey background
is it possible to make the font look bigger for the message part ?
Cheers
By bmortier on 2020-02-11T16:27:24 (imported from GitLab)
Edited by bmortier
changed milestone to %FusionDirectory 1.4
By bmortier on 2020-02-12T08:27:19 (imported from GitLab)
@bmortier Here’s what it looks like for the different dialog types:
Note that I removed all color, including text color which was dark red in previous screenshots. So only the icon is different between messages level. (while currently the whole pop-up is red/yellow/blue depending on level) This is what KDE also uses it seems.
Here are other possibilities for header text size:
First one is 24px which is @titlebar-font-sizein the theme and is used for login page title and other pages like this (recovery, public form, 2FA…). Second one is 18px Third one is 18px without bold, which what is used for page title inside FD, like «User management» for instance. (But it is the only text in all FD using 18px)Regarding the font size for the text in the dialog, I’m not sure it’s a good idea making it bigger as there is no other text bigger than this in FD, except for titles. Here are the sizes in breezy:
@body-font-size: 12px; @text-font-size: 12px; @title-font-size: 13px; @big-title-font-size: 14px; @small-text-font-size: 10px; @pluginfo-font-size: 11px; @titlebar-font-size: 24px;And the 18px mentioned above which is missing here and is only used for top header. So, this would mean adding a @big-text-font-size at 13 or 14, which would make it bigger than some titles, and would for now only be used for error dialogs?
By Côme Chilliet on 2020-02-12T09:19:28 (imported from GitLab)
Edited by bmortierBy Côme Chilliet on 2020-02-12T10:09:35 (imported from GitLab)
mentioned in commit 810c666e
By Côme Chilliet on 2020-02-12T10:15:58 (imported from GitLab)
mentioned in commit fb33328b
By Côme Chilliet on 2020-02-12T10:15:58 (imported from GitLab)
mentioned in commit 74d59a59
By Côme Chilliet on 2020-02-12T10:15:58 (imported from GitLab)
added fusiondirectory-core label and removed plugin-public-forms label
hello @MCMic,
i like the centered version
@jswaelens @ppenati what do you think ?
By bmortier on 2020-02-13T09:17:07 (imported from GitLab)
removed technical discussion label
added Changed label
