Triggers should not show the command on script error

Descriptive title for this enhancement

We should have an option on triggers to only show the result and not the full trigger error message

Actual behavior

when someting doesnt work in the trigger we get a message with the full error message + the result message and on some occasion we don't want this

Expected behavior

Only show the result message if there is an error and this option is selected

Step by step description of new behaviour

1. Create a user
2. Trigger fail
3. only show the result and not the full trigger error message

Benefits

don't scare user with incomprehensible error message don't show potential confidential info, ex password

Possible Drawbacks

none

Applicable Issues

Triggers

changed due date to February 11, 2020

By bmortier on 2020-02-11T09:10:08 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

By bmortier on 2020-02-11T09:10:08 (imported from GitLab)

added Bugs fusiondirectory-core labels

created merge request !737 to address this issue

By Côme Chilliet on 2020-02-11T09:22:36 (imported from GitLab)

mentioned in merge request !737

By Côme Chilliet on 2020-02-11T09:22:36 (imported from GitLab)

added PJ1802-0188 label

mentioned in commit fbd590c1

By Côme Chilliet on 2020-02-11T09:48:28 (imported from GitLab)

mentioned in commit c68e01d3

By Côme Chilliet on 2020-02-11T09:48:28 (imported from GitLab)

mentioned in commit c4f53dae

By Côme Chilliet on 2020-02-11T09:48:28 (imported from GitLab)

changed title from We should have an option on triggers to only show the result and not the full trigger error message to Triggers should not show the command on script error

By Côme Chilliet on 2020-02-11T10:42:35 (imported from GitLab)

added 2h of time spent at 2020-02-11

By Côme Chilliet on 2020-02-11T11:08:45 (imported from GitLab)

added To Be Tested label

removed Bugs label

assigned to @jswaelens and unassigned @MCMic

By bmortier on 2020-02-12T13:39:42 (imported from GitLab)

It just displayed the message from the hook now.

I also tested to enable shell debug and it's in journactl -u apache2 log

By Jonathan Swaelens on 2020-02-19T13:44:39 (imported from GitLab)

closed

By Jonathan Swaelens on 2020-02-19T13:44:40 (imported from GitLab)

added 1h of time spent at 2020-02-19

By Jonathan Swaelens on 2020-02-19T13:44:40 (imported from GitLab)

removed due date

By Jonathan Swaelens on 2020-02-19T13:44:40 (imported from GitLab)

added Changed label and removed To Be Tested label