hooks page not showing the field when we are not clicking on edit

Description

hooks page not showing the field when we are not clicking on edit

Distribution Name and Version

debian stretch

FusionDirectory Version

1.4-dev

PHP version used

7.0

Origin of php packages

fusiondirectory

Steps to Reproduce

1. go to demo-dev.fusiondirectory.org
2. log as admin
3. go to configuration hooks

we dont see all the fields see picture

Expected behavior:

see all the fiels like in edit mode

Actual behavior:

we see only checkbox and a empty box wich cause confusion and lets people think something is missing

Reproduces how often:

100%

Additional Information

changed due date to October 15, 2019

By bmortier on 2019-10-10T09:22:48 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

By bmortier on 2019-10-10T09:22:48 (imported from GitLab)

added PJ1802-0188 fusiondirectory-core labels

This is the result of the UI choices for read-only screens and disabled fields, explained in https://gitlab.fusiondirectory.org/fusiondirectory/fd/issues/5858

I think the weird feeling we get when seeing the hook tab comes from its emptiness and weird width of the values box (and of course because we are used to previous FD version UI).

I think a good way of improving this is to add column headers to hooks values, I will create an MR and add this since it will be useful anyway.

Here are the reasons why it’s good to have those fields hidden when not in edition mode:

1. It removes them when only reading the configuration, making it clearer.
2. It makes it clear that these are editing fields, sometimes people would fill them and save without adding the values before by mistake, but if they appear only in edition mode it is clearer that these are edition fields.
3. It hides them to people with only read rights on the configuration (a bit of a corner case, but remember that this behavior is not specific to this screen but consistent across all FD)

By Côme Chilliet on 2019-10-16T13:31:50 (imported from GitLab)

mentioned in merge request !698

By Côme Chilliet on 2019-10-16T13:31:57 (imported from GitLab)

created merge request !698 to address this issue

By Côme Chilliet on 2019-10-16T13:31:57 (imported from GitLab)

mentioned in commit d613c6f1

By Côme Chilliet on 2019-10-16T13:38:45 (imported from GitLab)

added 15m of time spent at 2019-10-16

By Côme Chilliet on 2019-10-16T13:44:43 (imported from GitLab)

added To Be Tested label

assigned to @jswaelens and unassigned @MCMic

By Côme Chilliet on 2019-10-16T13:44:43 (imported from GitLab)

Looks good.

By Jonathan Swaelens on 2019-10-22T12:50:00 (imported from GitLab)

closed

By Jonathan Swaelens on 2019-10-22T12:50:01 (imported from GitLab)

removed due date

By Jonathan Swaelens on 2019-10-22T12:50:01 (imported from GitLab)

added Added label and removed To Be Tested label

marked this issue as related to #5858 (closed)

By bmortier on 2021-01-28T20:55:37 (imported from GitLab)