Applying a template to a user removes the mail tab

Description

When applying a template to an existing object, fields which are not modified by the template should be left untouched.

Distribution Name and Version

Debian

FusionDirectory Version

1.4-dev

PHP version used

7.0

Origin of php packages

Debian

Steps to Reproduce

1. Create a template which only sets the description
2. Apply it to a user which has an active mail tab

Expected behavior:

Mail tab should be left untouched

Actual behavior:

Mail tab information is lost

Reproduces how often:

Additional Information

The password is also changed, because default values when creating a template saves setting password method to SSHA with an empty value. Not sure what is the best way to fix this (changing the default value or the way we handle it) but it should be looked into.

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2019-10-08T14:00:41 (imported from GitLab)

added PJ1811-0242 templates labels

changed the description

By Côme Chilliet on 2019-10-08T14:01:27 (imported from GitLab)

So this comes from the fact that the mailAccount tab uses the filter (mail=*), and that simplePlugin::adapt_from_template calls is_this_account on the $attrs array passed to it, which is incomplete and does not contain a mail field if the template is not changing its value.

By Côme Chilliet on 2019-10-08T14:41:38 (imported from GitLab)

created merge request !684 to address this issue

By Côme Chilliet on 2019-10-08T14:41:48 (imported from GitLab)

mentioned in merge request !684

By Côme Chilliet on 2019-10-08T14:41:48 (imported from GitLab)

mentioned in issue #6035

By Côme Chilliet on 2019-10-08T14:43:54 (imported from GitLab)

mentioned in commit 481d5f26

By Côme Chilliet on 2019-10-08T14:48:56 (imported from GitLab)

added 3h of time spent at 2019-10-08

By Côme Chilliet on 2019-10-08T14:52:22 (imported from GitLab)

added To Be Tested label

assigned to @jswaelens and unassigned @MCMic

By Côme Chilliet on 2019-10-08T14:52:22 (imported from GitLab)

added fusiondirectory-core label

created merge request !685 to address this issue

By Côme Chilliet on 2019-10-09T07:37:18 (imported from GitLab)

mentioned in merge request !685

By Côme Chilliet on 2019-10-09T07:37:19 (imported from GitLab)

https://jenkins.fusiondirectory.org/view/Selenium-Test/job/Selenium-Tests-Generic-1.4/plugin=core,vminfos=stretch_1_4/1429/

Template related test are failing

By Côme Chilliet on 2019-10-09T07:39:05 (imported from GitLab)

removed To Be Tested label

assigned to @MCMic and unassigned @jswaelens

By Côme Chilliet on 2019-10-09T07:39:06 (imported from GitLab)

mentioned in commit e045eea7

By Côme Chilliet on 2019-10-09T07:52:22 (imported from GitLab)

changed due date to October 09, 2019

By bmortier on 2019-10-09T09:02:41 (imported from GitLab)

created merge request !687 to address this issue

By Côme Chilliet on 2019-10-09T12:08:31 (imported from GitLab)

mentioned in merge request !687

By Côme Chilliet on 2019-10-09T12:08:32 (imported from GitLab)

mentioned in commit ba45d92a

By Côme Chilliet on 2019-10-09T12:13:14 (imported from GitLab)

Template tests passed (there are tests failure but not related to this issue)

By Côme Chilliet on 2019-10-09T13:36:30 (imported from GitLab)

added 3h of time spent at 2019-10-09

By Côme Chilliet on 2019-10-09T13:36:31 (imported from GitLab)

added To Be Tested label

assigned to @jswaelens and unassigned @MCMic

By Côme Chilliet on 2019-10-09T13:36:31 (imported from GitLab)

Tested on demo-dev and it work nicely. For the password it look that using %askme% let the password unchanged.

By Jonathan Swaelens on 2019-10-09T16:36:52 (imported from GitLab)

added 10m of time spent at 2019-10-09

By Jonathan Swaelens on 2019-10-09T16:36:53 (imported from GitLab)

removed due date

By Jonathan Swaelens on 2019-10-09T16:36:53 (imported from GitLab)

added Fixed label and removed To Be Tested label

@jswaelens For the password this will be looked at in #6035

By Côme Chilliet on 2019-10-10T06:57:55 (imported from GitLab)

closed

By Côme Chilliet on 2019-10-10T06:57:56 (imported from GitLab)

marked this issue as related to #6035

By bmortier on 2021-01-28T20:56:16 (imported from GitLab)

marked this issue as related to #5357 (closed)

By bmortier on 2021-01-28T20:56:46 (imported from GitLab)

changed the description

By bmortier on 2021-01-28T20:56:56 (imported from GitLab)