Typos in template masks should be better handled

Currently using a non-existing attribute in a template mask results in a PHP error, and a Fatal Error in FD:

Exception: Cannot traverse an already closed generator in /usr/share/fusiondirectory/include/class_templateHandling.inc:239
Stack trace:
#0 /usr/share/fusiondirectory/include/class_templateHandling.inc(195): templateHandling::parseString(NULL, Array, NULL, 'l', NULL)
#1 /usr/share/fusiondirectory/include/class_template.inc(362): templateHandling::parseArray(Array, Array, NULL)
#2 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(115): template->apply()
#3 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(62): templateDialog->handle_finish()
#4 /usr/share/fusiondirectory/include/management/class_management.inc(461): templateDialog->save_object()
#5 /usr/share/fusiondirectory/include/management/class_management.inc(1270): management->execute()
#6 /usr/share/fusiondirectory/include/class_pluglist.inc(565): management::mainInc()
#7 /usr/share/fusiondirectory/html/main.php(222): pluglist::runMainInc('189')
#8 {main}

Distribution Name and Version

Debian

FusionDirectory Version

1.4-dev

PHP version used

7.0

Origin of php packages

Debian

Steps to Reproduce

1. Use a mask like %asme% in a template
2. Use this template to create an object

Expected behavior:

Error message shown to the user. Template apply canceled.

Actual behavior:

PHP Error + Exception

Reproduces how often:

100%

Additional Information

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2019-10-08T10:00:34 (imported from GitLab)

added PJ1811-0242 templates labels

changed title from typos in attribute names in template masks should be better handled to Typos in template masks should be better handled

By Côme Chilliet on 2019-10-08T10:00:52 (imported from GitLab)

created merge request !683 to address this issue

By Côme Chilliet on 2019-10-08T10:01:28 (imported from GitLab)

mentioned in merge request !683

By Côme Chilliet on 2019-10-08T10:01:29 (imported from GitLab)

mentioned in commit e46995e0

By Côme Chilliet on 2019-10-08T10:48:47 (imported from GitLab)

added 2h of time spent at 2019-10-08

By Côme Chilliet on 2019-10-08T11:53:57 (imported from GitLab)

added To Be Tested label

assigned to @jswaelens and unassigned @MCMic

By Côme Chilliet on 2019-10-08T11:53:57 (imported from GitLab)

@bmortier Class templateDialog moved to its own file in include/management, is a packaging ticket needed?

By Côme Chilliet on 2019-10-08T11:54:55 (imported from GitLab)

added packaging label

changed due date to October 08, 2019

By bmortier on 2019-10-08T13:51:04 (imported from GitLab)

Tested with latest build and it's work correctly

By Jonathan Swaelens on 2019-10-08T16:10:46 (imported from GitLab)

closed

By Jonathan Swaelens on 2019-10-08T16:10:46 (imported from GitLab)

added 1h of time spent at 2019-10-08

By Jonathan Swaelens on 2019-10-08T16:10:47 (imported from GitLab)

removed To Be Tested label

added Fixed label

removed due date

By bmortier on 2021-01-28T20:57:36 (imported from GitLab)

added fusiondirectory-core label