Handling of booleans in CSV import
Handling of booleans in CSV import
It is hard and not intuitive to use boolean attributes in CSV import.
Actual behavior
Setting TRUE in fixed values or CSV data does not work, you have to put 1. (this was tested on force GID, should be tested on other boolean fields as well to check consistency)
Expected behavior
- Boolean attributes should show TRUE and FALSE options as does SelectAttributes, without the need to add fixed values by hand
- When using fixed values or CSV data, TRUE and FALSE string should be supported since this is the LDAP representation for booleans. 0/1 should also work. (for booleans which use another LDAP representation, it should also support their LDAP representation - unless it’s reversed true/false)
This changes may impact webservices as well (csv import uses serialization on templates which I think webservice also use, should be checked)
Activity
changed milestone to %FusionDirectory 1.4
By Jonathan Swaelens on 2019-09-06T09:04:52 (imported from GitLab)
added PJ1802-0188 + 1 deleted label
So, there is no coercing on the value when deserializing booleans, I think there should be. The problem is we do not know if we have LDAP value or something else. I guess the best we can do is use a heuristic that converts 0/false to false and 1/true to true. Whatever is in $falseValue should convert to false, unless it’s something usually TRUE.
We should refuse any value which is not a known one.
By Côme Chilliet on 2019-09-12T10:06:07 (imported from GitLab)
mentioned in commit f2a5b845
By Côme Chilliet on 2019-09-17T14:14:06 (imported from GitLab)
added To Be Tested label and removed 1 deleted label
assigned to @jswaelens and unassigned @MCMic
By Côme Chilliet on 2019-09-17T14:18:05 (imported from GitLab)
added Added label and removed To Be Tested label
