Cleanup session handling

Some crash we had recently seems related to sessions ( #6003 #6023 ).

There is an unused channel system in FD which dates from GOsa and I think was added to attempt to split session vars by browser tab or something like that.

To avoid session problems and make problems easier to debug I suggest we:

1. Remove the channel system
2. Remove the global_ methods and use always use set/get instead
3. Remove the reference returning in session::get. Using a reference on a session var is a bad idea and is most likely the source of some of our problems
4. Remove all calls to session_ functions outside of our session class and make sure everything goes through it.

changed milestone to %FusionDirectory 1.3.2

By Côme Chilliet on 2019-08-28T08:30:55 (imported from GitLab)

added 1 deleted label

I’m gonna do it first on 1.4 and make sure all tests are passing before doing the same for 1.3 branch.

By Côme Chilliet on 2019-08-28T08:33:51 (imported from GitLab)

created merge request !660 to address this issue

By Côme Chilliet on 2019-08-28T08:34:02 (imported from GitLab)

mentioned in merge request !660

By Côme Chilliet on 2019-08-28T08:34:04 (imported from GitLab)

mentioned in commit 3a4409e7

By Côme Chilliet on 2019-08-28T09:10:30 (imported from GitLab)

mentioned in commit b388c0db

By Côme Chilliet on 2019-08-28T09:10:30 (imported from GitLab)

mentioned in commit fa4578df

By Côme Chilliet on 2019-08-28T09:10:30 (imported from GitLab)

mentioned in commit d5ea9925

By Côme Chilliet on 2019-08-28T09:10:30 (imported from GitLab)

mentioned in commit 3e802798

By Côme Chilliet on 2019-08-28T09:10:30 (imported from GitLab)

added PJ1802-0188 fusiondirectory-core labels

changed milestone to %FusionDirectory 1.3.1

By bmortier on 2019-08-28T09:16:05 (imported from GitLab)

mentioned in commit b7428614

By Côme Chilliet on 2019-08-28T09:18:57 (imported from GitLab)

created merge request !661 to address this issue

By Côme Chilliet on 2019-08-28T12:28:17 (imported from GitLab)

mentioned in merge request !661

By Côme Chilliet on 2019-08-28T12:28:25 (imported from GitLab)

mentioned in commit c0648c48

By Côme Chilliet on 2019-08-28T12:58:09 (imported from GitLab)

mentioned in commit f65771f6

By Côme Chilliet on 2019-08-28T12:58:09 (imported from GitLab)

mentioned in commit 7aeeb7ae

By Côme Chilliet on 2019-08-28T12:58:10 (imported from GitLab)

mentioned in commit 188bbf75

By Côme Chilliet on 2019-08-28T12:58:10 (imported from GitLab)

mentioned in commit fe341a06

By Côme Chilliet on 2019-08-28T12:58:10 (imported from GitLab)

mentioned in commit d01108dd

By Côme Chilliet on 2019-08-28T12:58:10 (imported from GitLab)

added 2h 30m of time spent at 2019-08-28

By Côme Chilliet on 2019-08-28T15:12:13 (imported from GitLab)

mentioned in issue #6003

By Côme Chilliet on 2019-08-28T15:13:54 (imported from GitLab)

added 1 deleted label and removed 1 deleted label

closed

By bmortier on 2019-08-29T13:20:29 (imported from GitLab)

added Changed label

marked this issue as related to #6003

By bmortier on 2021-01-03T12:45:52 (imported from GitLab)