Email icon missing from core

Since https://gitlab.fusiondirectory.org/fusiondirectory/fd/issues/5840 fix, the recovery page Selenium test is almost always failing with a CSRF error.

It is quite hard to reproduce as it only happens on first try, and seems tightly related to the workflow used.

We should try to fix this one as some other CSRF protection related crash have been encountered and they may be related.

I should also note that any session problem, or manual URL tinkering may result in this kind of CSRF protection error.

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2019-08-27T13:12:53 (imported from GitLab)

added fusiondirectory-core label

Current trace:

By Côme Chilliet on 2019-08-27T13:13:42 (imported from GitLab)

created merge request !659 to address this issue

By Côme Chilliet on 2019-08-27T13:13:56 (imported from GitLab)

mentioned in merge request !659

By Côme Chilliet on 2019-08-27T13:13:56 (imported from GitLab)

mentioned in commit e9c574a2

By Côme Chilliet on 2019-08-27T13:18:49 (imported from GitLab)

The message indeed changed, so now we know that there is a token in the POST but not in the session. It’s expected that there is one in the POST, so the problem is with the session.

By Côme Chilliet on 2019-08-27T14:54:58 (imported from GitLab)

added 3h of time spent at 2019-08-27

By Côme Chilliet on 2019-08-27T14:54:47 (imported from GitLab)

mentioned in issue #6024

By Côme Chilliet on 2019-08-28T08:30:55 (imported from GitLab)

This was a hard one! So, final explanation:

• The password recovery page uses the icon internet-mail
• This icon is in the mail plugin, so it is missing
• This triggers a PHP error in the getbin.php file
• In test VMs, all PHP errors are treated as fatal, to make sure there are no PHP error in the final product
• When a fatal error is encountered, FD destroys the session, to make sure the user does not end up in a loop (session data causes a fatal error)
• Because the session is destroyed (by the missing icon getbin.php request), the CSRF token is lost, thus the crash

So the crash was specific to test VM setup.

And the fix is moving the internet-mail.png file to core.

By Côme Chilliet on 2019-08-28T14:53:59 (imported from GitLab)

added PJ1802-0188 label

changed title from Recovery test failing because of CSRF protection to Email icon missing from core

By Côme Chilliet on 2019-08-28T14:56:24 (imported from GitLab)

created merge request !662 to address this issue

By Côme Chilliet on 2019-08-28T14:56:46 (imported from GitLab)

mentioned in merge request !662

By Côme Chilliet on 2019-08-28T14:56:46 (imported from GitLab)

mentioned in commit d85daf4a

By Côme Chilliet on 2019-08-28T15:05:52 (imported from GitLab)

mentioned in issue fd-plugins#5992 (closed)

By Côme Chilliet on 2019-08-28T15:07:06 (imported from GitLab)

mentioned in merge request !663

By Côme Chilliet on 2019-08-28T15:10:51 (imported from GitLab)

added 1 deleted label

changed milestone to %FusionDirectory 1.3.1

By Côme Chilliet on 2019-08-28T15:11:26 (imported from GitLab)

added packaging label