Skip to content
GitLab
Closed
Issue created by bmortier@bmortierMaintainer

Crash at index.php when we already have a session

Closed

Crash at index.php when we already have a session

When we have a session from recovery or user-reminder postpone page and we go to the index, if we use the encrypted password feature, it crashes in Language::init because set_current was not called on $config yet.

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Activity

    • bmortier changed milestone to %FusionDirectory 1.4

      changed milestone to %FusionDirectory 1.4

      By Côme Chilliet on 2019-07-15T15:12:27 (imported from GitLab)

    • bmortier added fusiondirectory-core label

      added fusiondirectory-core label

    • bmortier mentioned in merge request !631

      mentioned in merge request !631

      By Côme Chilliet on 2019-07-15T15:12:42 (imported from GitLab)

    • bmortier created merge request !631 to address this issue

      created merge request !631 to address this issue

      By Côme Chilliet on 2019-07-15T15:12:42 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Harder to fix than anticipated…

      I think the best way to fix this is to remove the need to access the LDAP from pluglist::load, by refactoring/cleaning the department handling in $config.

      The plan:

      • Make departments/idepartments/department_info private
      • Add a function to get them
      • Build them at first call

      It may even make sense to move this in an other class since they are not config related.

      By Côme Chilliet on 2019-07-15T15:38:31 (imported from GitLab)

    • bmortier added 2h of time spent at 2019-07-15

      added 2h of time spent at 2019-07-15

      By Côme Chilliet on 2019-07-15T15:38:32 (imported from GitLab)

    • bmortier mentioned in commit 1a74c4d1

      mentioned in commit 1a74c4d1

      By Côme Chilliet on 2019-07-16T09:12:20 (imported from GitLab)

    • bmortier mentioned in issue fd-plugins#5975 (closed)

      mentioned in issue fd-plugins#5975 (closed)

      By Côme Chilliet on 2019-07-16T09:13:19 (imported from GitLab)

    • bmortier added PJ1802-0188 label

      added PJ1802-0188 label

    • bmortier added 3h of time spent at 2019-07-16

      added 3h of time spent at 2019-07-16

      By Côme Chilliet on 2019-07-16T10:12:18 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      hello @MCMic,

      yes i agree with the cleaning. Moving this to another class seems a nice idea

      Cheers

      By bmortier on 2019-07-16T21:30:06 (imported from GitLab)

    • bmortier added 5m of time spent at 2019-07-16

      added 5m of time spent at 2019-07-16

      By bmortier on 2019-07-16T21:30:06 (imported from GitLab)

    • bmortier changed due date to July 17, 2019

      changed due date to July 17, 2019

      By bmortier on 2019-07-16T21:30:13 (imported from GitLab)

    • bmortier mentioned in merge request !633

      mentioned in merge request !633

      By Côme Chilliet on 2019-07-17T08:24:37 (imported from GitLab)

    • bmortier created merge request !633 to address this issue

      created merge request !633 to address this issue

      By Côme Chilliet on 2019-07-17T08:24:37 (imported from GitLab)

    • bmortier mentioned in commit 7a1bb9d5

      mentioned in commit 7a1bb9d5

      By Côme Chilliet on 2019-07-17T08:25:52 (imported from GitLab)

    • bmortier closed

      closed

      By Côme Chilliet on 2019-07-18T09:15:47 (imported from GitLab)

    • bmortier added Fixed label

      added Fixed label

    • bmortier removed due date

      removed due date

      By bmortier on 2020-04-22T12:23:16 (imported from GitLab)

    • bmortier marked this issue as related to fd-plugins#5975 (closed)

      marked this issue as related to fd-plugins#5975 (closed)

      By bmortier on 2021-01-28T21:13:37 (imported from GitLab)

    Please register or sign in to reply