Error if the admin DN is not correct when the setup

Description

If the admin DN is incorrect when we click on verify we have that

 Fatal error: Uncaught TypeError: Return value of setupStepLdap::check() must be of the type array, none returned in /usr/share/fusiondirectory/setup/class_setupStepLdap.inc:222 Stack trace: #0 /usr/share/fusiondirectory/setup/class_setup.inc(108): setupStepLdap->check() #1 /usr/share/fusiondirectory/setup/class_setup.inc(308): setup->save_object() #2 /usr/share/fusiondirectory/html/setup.php(104): setup::mainInc() #3 {main} thrown in /usr/share/fusiondirectory/setup/class_setupStepLdap.inc on line 222

Distribution Name and Version

Centos 7

FusionDirectory Version

1.4

PHP version used

7

Origin of php packages

Remi repo

Steps to Reproduce

1. Setup FD
2. Insert a wrong admin DN like "cn=admin,dc=nodomain instead of cn=Manger,dc=mydomain)

Expected behavior:

No php errors

Actual behavior:

There is a php error

Reproduces how often: 100

added Bugs label

added PJ1801-0146 label

mentioned in merge request !573

By Côme Chilliet on 2019-04-16T15:05:51 (imported from GitLab)

created merge request !573 to address this issue

By Côme Chilliet on 2019-04-16T15:05:52 (imported from GitLab)

mentioned in commit 118f001b

By Côme Chilliet on 2019-04-16T15:08:50 (imported from GitLab)

added 30m of time spent at 2019-04-16

By Côme Chilliet on 2019-04-16T15:29:11 (imported from GitLab)

added To Be Tested label

changed milestone to %FusionDirectory 1.4

By bmortier on 2019-04-23T07:01:48 (imported from GitLab)

hello @MCMic,

is this fix to be propagated to 1.3-fixes ?

Cheers

By bmortier on 2019-05-23T14:53:16 (imported from GitLab)

No, this is related to strict typing added to 1.4 only.

By Côme Chilliet on 2019-05-23T14:53:16 (imported from GitLab)

removed Bugs label

Tested on a new RHEL install and I don't reproduce the issue

By Jonathan Swaelens on 2019-05-23T14:54:23 (imported from GitLab)

closed

By Jonathan Swaelens on 2019-05-23T14:54:23 (imported from GitLab)

added 40m of time spent at 2019-05-23

By Jonathan Swaelens on 2019-05-23T14:54:24 (imported from GitLab)

removed To Be Tested label

added Fixed To Be Tested labels

removed To Be Tested label

added fusiondirectory-core label