Special hook attrs are not available to other tabs

Actual behavior

When a hook have special attrs for hook, for instance user has 'passwordMethod', 'userLocked' and 'passwordClear', they are not available to hook on other tabs of the same object.

Expected behavior

Be able to have a postmodify hook on samba tab which makes use of %passwordClear%.

Step by step description of new behaviour

1. Instead of doing foreach ($object->attributes as $attr) { in callHook, call a method on the object which fills $addAttrs
2. In this method, user can provide passwordClear and the others on top of their other attributes

Benefits

Access special attributes on hooks on other tabs

Possible Drawbacks

Applicable Issues

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2019-03-27T14:22:50 (imported from GitLab)

created merge request !565 to address this issue

By Côme Chilliet on 2019-03-27T14:25:57 (imported from GitLab)

mentioned in merge request !565

By Côme Chilliet on 2019-03-27T14:26:06 (imported from GitLab)

mentioned in issue fd-plugins#5938 (closed)

By Côme Chilliet on 2019-03-27T14:32:31 (imported from GitLab)

added PJ1802-0188 fusiondirectory-core labels

changed due date to June 05, 2019

By bmortier on 2019-06-04T09:29:04 (imported from GitLab)

mentioned in merge request !598

By Côme Chilliet on 2019-06-05T09:09:59 (imported from GitLab)

created merge request !598 to address this issue

By Côme Chilliet on 2019-06-05T09:10:00 (imported from GitLab)

mentioned in commit 3a8a838e

By Côme Chilliet on 2019-06-06T14:22:01 (imported from GitLab)

mentioned in issue fd-plugins#5960 (closed)

By Côme Chilliet on 2019-06-06T14:23:16 (imported from GitLab)

mentioned in commit 7af41ff1

By Côme Chilliet on 2019-06-06T14:37:54 (imported from GitLab)

Should be good.

By Côme Chilliet on 2019-06-06T15:01:35 (imported from GitLab)

added 1h of time spent at 2019-06-06

By Côme Chilliet on 2019-06-06T15:01:36 (imported from GitLab)

added To Be Tested label

assigned to @jswaelens and unassigned @MCMic

By Côme Chilliet on 2019-06-06T15:01:36 (imported from GitLab)

Tested with %passwordClear% on sambaAccount hook (as postmodify).

I could see the passwordClear in the hook like expected

By Jonathan Swaelens on 2019-06-12T15:28:09 (imported from GitLab)

closed

By Jonathan Swaelens on 2019-06-12T15:28:10 (imported from GitLab)

added 10m of time spent at 2019-06-12

By Jonathan Swaelens on 2019-06-12T15:28:10 (imported from GitLab)

removed due date

By Jonathan Swaelens on 2019-06-12T15:28:10 (imported from GitLab)

added Changed label and removed To Be Tested label