icons missing in filter selections in core
icons missing in filter selections in core
Description
icons missing in filter selections in core FusionDirectory
Distribution Name and Version
Debian stretch 9.0
FusionDirectory Version
1.4-dev
PHP version used
7.0
Origin of php packages
Debian stretch 9.0
Steps to Reproduce
- got to department and see the missing icons in tabs
- got to sympa and see the missing icons in tabs
- got to systems and see the missing icons in tabs
Expected behavior:
have the icons next the to label in tabs list
Actual behavior:
icons doenst appears
Reproduces how often:
100%
Additional Information
- Are we missing small 16px versions of those icons
- Should we ask the designer to produce the missing icons
Activity
added PJ1802-0188 filters labels
mentioned in issue fd-plugins#5936 (closed)
By Côme Chilliet on 2019-03-26T15:55:05 (imported from GitLab)
mentioned in commit 410e0895
By Côme Chilliet on 2019-03-26T16:27:51 (imported from GitLab)
changed milestone to %FusionDirectory 1.4
By Côme Chilliet on 2019-03-26T16:28:27 (imported from GitLab)
With this and fd-plugins#5936 (closed) it should be better
By Côme Chilliet on 2019-03-26T16:29:17 (imported from GitLab)
Note: I only looked into tabs appearing in the tab filter element. We may also want to look into tabs we want to appear in the properties column if people add it to the management classes of any plugin. (A tab which is always activated will not appear in the filter box but can appear in the properties column if it has an icon)
By Côme Chilliet on 2019-03-26T16:33:00 (imported from GitLab)
hello @mcmic,
yes i prepared a mail for @animtim to ask for the missing icons.
what do you mean by :
We may also want to look into tabs we want to appear in the properties column if people add it to the management classes of any plugin. (A tab which is always activated will not appear in the filter box but can appear in the properties column if it has an icon)
we need to make some change in our code for this to work, or we need 16px icon for all tabs that need to appear in properties column
Cheers
By bmortier on 2019-03-27T16:11:10 (imported from GitLab)
we need to make some change in our code for this to work, or we need 16px icon for all tabs that need to appear in properties column
Both, if a user adds a Properties column to a management class, only tabs which have plSmallIcon filled in will appear (for active tabs). On management classes where there is no Properties column by default, this was not tested and most likely icons are missing.
By Côme Chilliet on 2019-04-01T07:33:38 (imported from GitLab)
added To Be Tested label
added Added label and removed To Be Tested label
added fusiondirectory-core label
