Skip to content
GitLab
Closed
Issue created by bmortier@bmortierMaintainer

Use only selectManagement for selection dialogs

Closed

Use only selectManagement for selection dialogs

This was a subtask of #5135 but it’s big enough to have its own ticket so that #5135 can be closed and issues more specific opened, to avoid having too much MR/commits tied to a single issue.

selectManagement needs to be improved and last occurences of simpleSelectManagement removed.

The configuration dialog for selectManagement is currently broken since its buttons are intercepted by the parent management class it seems.

simpleSelectManagement is still used for:

  • include/select/systemSelect/class_systemSelect.inc:class systemSelect extends simpleSelectManagement
  • include/select/groupSelect/class_groupSelect.inc:class groupSelect extends simpleSelectManagement
  • include/simpleplugin/attributes/class_PhoneNumberAttribute.inc:class phoneSelect extends simpleSelectManagement

And in plugins:

  • samba/personal/samba/class_sambaAccount.inc:class winstationSelect extends simpleSelectManagement
  • gpg/personal/gpg/pgpKeySelect/class_pgpKeySelect.inc:class pgpKeySelect extends simpleSelectManagement
  • netgroups/admin/netgroups/memberNisnetgroupSelect/class_memberNisnetgroupSelect.inc:class memberNisnetgroupSelect extends simpleSelectManagement
  • ejbca/admin/ejbca/class_ejbcaCertSelect.inc:class ejbcaCertificateSelectManagement extends simpleSelectManagement
  • mail/personal/mail/mailAddressSelect/class_mailAddressSelect.inc:class mailAddressSelect extends simpleSelectManagement
  • fai/admin/fai/packageSelect/class_packageSelect.inc:class packageSelect extends simpleSelectManagement
Edited by bmortier

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Activity

    • bmortier changed milestone to %FusionDirectory 1.4

      changed milestone to %FusionDirectory 1.4

      By Côme Chilliet on 2019-03-11T14:21:22 (imported from GitLab)

    • bmortier mentioned in issue #5135

      mentioned in issue #5135

      By Côme Chilliet on 2019-03-11T14:26:33 (imported from GitLab)

    • bmortier added PJ1802-0188 filters labels

      added PJ1802-0188 filters labels

    • bmortier changed title from Use selectManagement only for selection dialogs to Use only selectManagement for selection dialogs

      changed title from Use selectManagement only for selection dialogs to Use only selectManagement for selection dialogs

      By Côme Chilliet on 2019-03-27T10:41:29 (imported from GitLab)

    • bmortier mentioned in issue fd-plugins#5937 (closed)

      mentioned in issue fd-plugins#5937 (closed)

      By Côme Chilliet on 2019-03-27T10:54:53 (imported from GitLab)

    • bmortier created merge request !564 to address this issue

      created merge request !564 to address this issue

      By Côme Chilliet on 2019-03-27T12:36:39 (imported from GitLab)

    • bmortier mentioned in merge request !564

      mentioned in merge request !564

      By Côme Chilliet on 2019-03-27T12:36:39 (imported from GitLab)

    • bmortier mentioned in commit 72e5221d

      mentioned in commit 72e5221d

      By Côme Chilliet on 2019-03-27T13:32:05 (imported from GitLab)

    • bmortier mentioned in commit 99605d37

      mentioned in commit 99605d37

      By Côme Chilliet on 2019-03-27T13:32:05 (imported from GitLab)

    • bmortier mentioned in commit 9f4cd8c9

      mentioned in commit 9f4cd8c9

      By Côme Chilliet on 2019-03-27T13:32:05 (imported from GitLab)

    • bmortier mentioned in commit 5f20f60f

      mentioned in commit 5f20f60f

      By Côme Chilliet on 2019-03-27T15:04:40 (imported from GitLab)

    • bmortier mentioned in commit 4e9d4006

      mentioned in commit 4e9d4006

      By Côme Chilliet on 2019-03-27T16:31:38 (imported from GitLab)

    • bmortier mentioned in commit 990c67f0

      mentioned in commit 990c67f0

      By Côme Chilliet on 2019-04-01T07:27:43 (imported from GitLab)

    • bmortier added 4h of time spent at 2019-04-01

      added 4h of time spent at 2019-04-01

      By Côme Chilliet on 2019-04-01T07:29:10 (imported from GitLab)

    • bmortier mentioned in commit 182fb355

      mentioned in commit 182fb355

      By Côme Chilliet on 2019-04-01T13:44:18 (imported from GitLab)

    • bmortier mentioned in commit 55e13734

      mentioned in commit 55e13734

      By Côme Chilliet on 2019-04-02T13:48:42 (imported from GitLab)

    • bmortier mentioned in commit d6e4c9ba

      mentioned in commit d6e4c9ba

      By Côme Chilliet on 2019-04-02T13:48:42 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Note: blacklisting/whitelisting system needs to be added to selectManagement, it’s missing at the moment. It should not use the session like the simpleSelectManagement class was doing but do something cleaner. (either the selectManagement access the attribute objects, or the attribute objects directly gives the listings to the constructor).

      By Côme Chilliet on 2019-04-02T14:26:42 (imported from GitLab)

    • bmortier mentioned in commit 4f6175ca

      mentioned in commit 4f6175ca

      By Côme Chilliet on 2019-04-02T14:29:26 (imported from GitLab)

    • bmortier added 2d of time spent at 2019-04-02

      added 2d of time spent at 2019-04-02

      By Côme Chilliet on 2019-04-02T15:32:18 (imported from GitLab)

    • bmortier mentioned in merge request !566

      mentioned in merge request !566

      By Côme Chilliet on 2019-04-03T08:01:28 (imported from GitLab)

    • bmortier created merge request !566 to address this issue

      created merge request !566 to address this issue

      By Côme Chilliet on 2019-04-03T08:01:28 (imported from GitLab)

    • bmortier mentioned in commit fed2d6b6

      mentioned in commit fed2d6b6

      By Côme Chilliet on 2019-04-03T08:05:21 (imported from GitLab)

    • bmortier mentioned in commit dd1d1971

      mentioned in commit dd1d1971

      By Côme Chilliet on 2019-04-03T08:05:21 (imported from GitLab)

    • bmortier added 3h of time spent at 2019-04-03

      added 3h of time spent at 2019-04-03

      By Côme Chilliet on 2019-04-03T15:25:45 (imported from GitLab)

    • bmortier created merge request !568 to address this issue

      created merge request !568 to address this issue

      By Côme Chilliet on 2019-04-04T07:52:47 (imported from GitLab)

    • bmortier mentioned in merge request !568

      mentioned in merge request !568

      By Côme Chilliet on 2019-04-04T07:52:47 (imported from GitLab)

    • bmortier mentioned in commit 443edfaf

      mentioned in commit 443edfaf

      By Côme Chilliet on 2019-04-04T08:02:04 (imported from GitLab)

    • bmortier added 2h of time spent at 2019-04-16

      added 2h of time spent at 2019-04-16

      By Côme Chilliet on 2019-04-16T15:05:18 (imported from GitLab)

    • bmortier mentioned in merge request !574

      mentioned in merge request !574

      By Côme Chilliet on 2019-04-17T13:49:17 (imported from GitLab)

    • bmortier created merge request !574 to address this issue

      created merge request !574 to address this issue

      By Côme Chilliet on 2019-04-17T13:49:17 (imported from GitLab)

    • bmortier mentioned in commit 188814d8

      mentioned in commit 188814d8

      By Côme Chilliet on 2019-04-17T14:15:26 (imported from GitLab)

    • bmortier mentioned in commit f5dc27cc

      mentioned in commit f5dc27cc

      By Côme Chilliet on 2019-04-17T14:15:26 (imported from GitLab)

    • bmortier mentioned in commit a65d6de7

      mentioned in commit a65d6de7

      By Côme Chilliet on 2019-04-17T14:42:00 (imported from GitLab)

    • bmortier mentioned in commit 36a45fc5

      mentioned in commit 36a45fc5

      By Côme Chilliet on 2019-04-17T14:55:55 (imported from GitLab)

    • bmortier added 4h of time spent at 2019-04-17

      added 4h of time spent at 2019-04-17

      By Côme Chilliet on 2019-04-17T15:10:23 (imported from GitLab)

    • bmortier mentioned in merge request !575

      mentioned in merge request !575

      By Côme Chilliet on 2019-04-18T07:24:43 (imported from GitLab)

    • bmortier created merge request !575 to address this issue

      created merge request !575 to address this issue

      By Côme Chilliet on 2019-04-18T07:24:43 (imported from GitLab)

    • bmortier mentioned in commit d97dc85c

      mentioned in commit d97dc85c

      By Côme Chilliet on 2019-04-18T07:25:50 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Only packageSelect and pgpKeySelect are not migrated, all the rest can be tested.

      By Côme Chilliet on 2019-04-24T07:38:11 (imported from GitLab)

    • bmortier added To Be Tested label

      added To Be Tested label

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      pgpKeySelect is hard to migrate because our GPG plugin is not working properly with gpg 2.1. They modified LDAP support, the syntax to push GPG key is complicated and not documented (I found it here: https://lists.gnupg.org/pipermail/gnupg-devel/2015-March/029607.html) And it seems GPG does not push any other info than the key itself in the LDAP now. So fields pgpDisabled $ pgpKeyID $ pgpKeyType $ pgpUserID $ pgpKeyCreateTime $ pgpSignerID $ pgpRevoked $ pgpSubKeyID $ pgpKeySize $ pgpKeyExpireTime are left empty.

      By Côme Chilliet on 2019-04-24T08:23:31 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      It appears the second problem is known and has a patch pending: https://dev.gnupg.org/T4447

      By Côme Chilliet on 2019-04-24T15:04:22 (imported from GitLab)

    • bmortier assigned to @jswaelens and unassigned @MCMic

      assigned to @jswaelens and unassigned @MCMic

      By bmortier on 2019-05-31T14:38:12 (imported from GitLab)

    • bmortier changed due date to June 04, 2019

      changed due date to June 04, 2019

      By bmortier on 2019-05-31T14:38:15 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Tested on demo-dev with selecting user(s) for manager/roles/acl and ogroup.

      It works perfectly

      By Jonathan Swaelens on 2019-06-06T14:53:32 (imported from GitLab)

    • bmortier closed

      closed

      By Jonathan Swaelens on 2019-06-06T14:53:33 (imported from GitLab)

    • bmortier added 10m of time spent at 2019-06-06

      added 10m of time spent at 2019-06-06

      By Jonathan Swaelens on 2019-06-06T14:53:34 (imported from GitLab)

    • bmortier added Changed label and removed To Be Tested label

      added Changed label and removed To Be Tested label

    • bmortier removed due date

      removed due date

      By Jonathan Swaelens on 2019-06-06T14:53:37 (imported from GitLab)

    • bmortier mentioned in issue fd-plugins#6006 (closed)

      mentioned in issue fd-plugins#6006 (closed)

      By Côme Chilliet on 2019-10-24T07:56:45 (imported from GitLab)

    • bmortier marked this issue as related to #5135

      marked this issue as related to #5135

      By bmortier on 2021-01-29T14:48:17 (imported from GitLab)

    Please register or sign in to reply