Use PHP7 array syntax

PHP now allows the [] syntax for arrays instead of array().

We should make the change and use this new syntax in FD, and adapt our code review profile to detect uses of the old syntax.

Advantages:

• less verbose for small and empty arrays
• clear indication that we are closing an array and not a function on multilines arrays
• symmetry with new list syntax (in PHP 7.1)

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2019-02-13T11:00:41 (imported from GitLab)

added PJ1802-0188 label

added 1 deleted label

changed the description

By Côme Chilliet on 2019-02-13T11:15:00 (imported from GitLab)

changed the description

By Côme Chilliet on 2019-02-13T11:15:09 (imported from GitLab)

mentioned in merge request !536

By Côme Chilliet on 2019-02-25T16:08:54 (imported from GitLab)

created merge request !536 to address this issue

By Côme Chilliet on 2019-02-25T16:08:55 (imported from GitLab)

mentioned in commit e7a2d4d9

By Côme Chilliet on 2019-02-25T16:31:22 (imported from GitLab)

mentioned in commit 43447205

By Côme Chilliet on 2019-02-25T16:31:22 (imported from GitLab)

mentioned in commit 85412c5d

By Côme Chilliet on 2019-02-25T16:31:22 (imported from GitLab)

mentioned in issue fd-plugins#5925 (closed)

By Côme Chilliet on 2019-02-26T09:45:24 (imported from GitLab)

mentioned in commit f8839bf4

By Côme Chilliet on 2019-02-26T10:06:53 (imported from GitLab)

added 4h of time spent at 2019-02-26

By Côme Chilliet on 2019-02-26T16:34:25 (imported from GitLab)

closed

By Côme Chilliet on 2019-02-26T16:34:39 (imported from GitLab)

marked this issue as related to fd-plugins#5925 (closed)

By bmortier on 2021-01-29T20:37:40 (imported from GitLab)

added Changed label