PHP >= 7.2 triggering error when count() is called with invalid countable

With PHP > 7.2 count() returns a warning when called on an uncountable (https://secure.php.net/manual/en/function.count.php#refsect1-function.count-changelog)

All credits for finding the problem goes to MCMic_w on #fusiondirectory

Traceback:

=== /Error === 
=== Trace ===
Trace[1]:class objects / function ls
File : /usr/share/webapps/fusiondirectory/plugins/personal/roles/class_userRoles.inc
Line : 103
Type : static
  array("ogroup"),"cn","dc=example,dc=de","(member=uid=aea-fd-admin,ou=people,dc=example,dc=de)"

Trace[2]:class userRoles / function __construct
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleTabs.inc
Line : 92
Type : method
  "cn=cloud-user,ou=groups,dc=example,dc=de",CLASS: user,CLASS: simpleTabs,""

Trace[3]:class simpleTabs / function __construct
File : /usr/share/webapps/fusiondirectory/include/class_objects.inc
Line : 249
Type : method
  "USER","uid=aea-fd-admin,ou=people,dc=example,dc=de"

Trace[4]:class objects / function open
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 878
Type : static
  "uid=aea-fd-admin,ou=people,dc=example,dc=de","USER"

Trace[5]:class simpleManagement / function editEntry
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 929
Type : method
  "edit",array(),array(array("uid=aea-fd-admin,ou=people,dc=example,dc=de"),"edit")

Trace[6]:class simpleManagement / function handleActions
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 556
Type : method
  array(array("uid=aea-fd-admin,ou=people,dc=example,dc=de"),"edit")

Trace[7]:class simpleManagement / function execute
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 1339
Type : method
  -

Trace[8]:class simpleManagement / function mainInc
File : /usr/share/webapps/fusiondirectory/plugins/admin/users/main.inc
Line : 22
Type : static
  "userManagement"

Trace[9]:function require
File : /usr/share/webapps/fusiondirectory/html/main.php
Line : 284
Type : -
  "/usr/share/webapps/fusiondirectory/plugins/admin/users/main.inc"
=== /Trace ====== Error === PHP error: count(): Parameter must be an array or an object that implements Countable (/usr/share/webapps/fusiondirectory/include/class_objects.inc, line 73)
=== /Error === 
=== Trace ===
Trace[1]:class objects / function ls
File : /usr/share/webapps/fusiondirectory/plugins/personal/roles/class_userRoles.inc
Line : 140
Type : static
  array("role"),"cn","dc=example,dc=de","(roleOccupant=uid=aea-fd-admin,ou=people,dc=example,dc=de)"

Trace[2]:class userRoles / function __construct
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleTabs.inc
Line : 92
Type : method
  "cn=cloud-user,ou=groups,dc=example,dc=de",CLASS: user,CLASS: simpleTabs,""

Trace[3]:class simpleTabs / function __construct
File : /usr/share/webapps/fusiondirectory/include/class_objects.inc
Line : 249
Type : method
  "USER","uid=aea-fd-admin,ou=people,dc=example,dc=de"

Trace[4]:class objects / function open
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 878
Type : static
  "uid=aea-fd-admin,ou=people,dc=example,dc=de","USER"

Trace[5]:class simpleManagement / function editEntry
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 929
Type : method
  "edit",array(),array(array("uid=aea-fd-admin,ou=people,dc=example,dc=de"),"edit")

Trace[6]:class simpleManagement / function handleActions
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 556
Type : method
  array(array("uid=aea-fd-admin,ou=people,dc=example,dc=de"),"edit")

Trace[7]:class simpleManagement / function execute
File : /usr/share/webapps/fusiondirectory/include/simpleplugin/class_simpleManagement.inc
Line : 1339
Type : method
  -

Trace[8]:class simpleManagement / function mainInc
File : /usr/share/webapps/fusiondirectory/plugins/admin/users/main.inc
Line : 22
Type : static
  "userManagement"

Trace[9]:function require
File : /usr/share/webapps/fusiondirectory/html/main.php
Line : 284
Type : -
  "/usr/share/webapps/fusiondirectory/plugins/admin/users/main.inc"
=== /Trace ===```

assigned to @MCMic

By Côme Chilliet on 2019-01-17T13:18:38 (imported from GitLab)

added Bugs fusiondirectory-core labels

By Côme Chilliet on 2019-01-17T13:28:15 (imported from GitLab)

changed milestone to %FusionDirectory 1.2.4

By Côme Chilliet on 2019-01-17T13:28:18 (imported from GitLab)

created branch 5942-php-7-2-producing-error-when-count-is-called-with-invalid-countable

By Côme Chilliet on 2019-01-17T13:28:51 (imported from GitLab)

mentioned in merge request !496

By Côme Chilliet on 2019-01-17T13:29:04 (imported from GitLab)

mentioned in commit 168630ad

By Côme Chilliet on 2019-01-17T13:57:25 (imported from GitLab)

changed title from php > 7.2 producing error when count() is called with invalid countable to PHP >= 7.2 producing error when count() is called with invalid countable

By Côme Chilliet on 2019-01-17T13:58:23 (imported from GitLab)

changed title from PHP >= 7.2 producing error when count() is called with invalid countable to PHP >= 7.2 triggering error when count() is called with invalid countable

By Côme Chilliet on 2019-01-17T13:58:38 (imported from GitLab)

created branch 5942-php-7-2-producing-error-when-count-is-called-with-invalid-countable-2

By Côme Chilliet on 2019-01-17T13:59:00 (imported from GitLab)

mentioned in merge request !497

By Côme Chilliet on 2019-01-17T13:59:13 (imported from GitLab)

mentioned in commit 35bbb2bb

By Côme Chilliet on 2019-01-17T14:00:32 (imported from GitLab)

mentioned in issue fd-plugins#5908 (closed)

By Côme Chilliet on 2019-01-17T14:18:01 (imported from GitLab)

created branch 5942-php-7-2-triggering-error-when-count-is-called-with-invalid-countable

By Côme Chilliet on 2019-01-17T14:30:36 (imported from GitLab)

mentioned in merge request !498

By Côme Chilliet on 2019-01-17T14:30:39 (imported from GitLab)

mentioned in commit f8482edc

By Côme Chilliet on 2019-01-17T14:36:46 (imported from GitLab)

added To Be Tested label

By Côme Chilliet on 2019-01-17T14:37:26 (imported from GitLab)

removed Bugs label

By bmortier on 2019-01-23T12:00:09 (imported from GitLab)

added PJ1802-0188 label

assigned to @jswaelens and unassigned @MCMic

By bmortier on 2019-06-04T09:36:31 (imported from GitLab)

changed due date to June 05, 2019

By bmortier on 2019-06-04T09:37:05 (imported from GitLab)

changed milestone to %FusionDirectory 1.3.1

By Jonathan Swaelens on 2019-06-13T13:55:31 (imported from GitLab)

added Fixed label and removed To Be Tested label

removed due date

By bmortier on 2019-06-27T19:47:21 (imported from GitLab)

closed

By bmortier on 2019-06-27T19:47:22 (imported from GitLab)

mentioned in issue dev-tools#19 (closed)

By bmortier on 2019-06-28T20:53:42 (imported from GitLab)