Ldap filter parsing issue

Description

There is an error when using the webservice along with a valid ldap filter and attributes.

Distribution Name and Version

Debian 9.5

FusionDirectory Version

1.2-2~jenkinsbuild826

PHP version used

PHP7

Origin of php packages

FD

Steps to Reproduce

Webservice call:

CALL: LS [xxx, user, [fdContractStartDate:1, co:1], ou=people,dc=xxx,dc=yyy, (&(fdContractStartDate>=20180820000000Z)(fdContractStartDate<=20180919000000Z))]

ERROR: Could not find ACL for attribute "fdContractStartDate>"

Expected behavior:

no error, result returned

assigned to @MCMic

By Côme Chilliet on 2018-09-19T08:20:22 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2018-09-19T08:33:40 (imported from GitLab)

added PJ1802-0188 label

By Côme Chilliet on 2018-09-19T08:33:56 (imported from GitLab)

added PJ1710-0130 and removed PJ1802-0188 labels

By Côme Chilliet on 2018-09-19T09:15:33 (imported from GitLab)

created branch 5889-ldap-filter-parsing-issue

By Côme Chilliet on 2018-09-19T09:15:44 (imported from GitLab)

mentioned in merge request !397

By Côme Chilliet on 2018-09-19T09:15:47 (imported from GitLab)

mentioned in commit 560c244c

By Côme Chilliet on 2018-09-19T10:18:51 (imported from GitLab)

added 1h of time spent at 2018-09-19

By Côme Chilliet on 2018-09-19T13:50:04 (imported from GitLab)

I tried the patch which available at the merge request.

FD has priorly been upgraded to 1.2.2-1 (from 1.2.1-1).

Then I cd to /usr/share/fusiondirectory/include issue : patch -p1 class_ldapFilter.inc < ~/397.diff and get the following results:

patching file class_ldapFilter.inc
Hunk #2 FAILED at 122.
Hunk #3 succeeded at 126 with fuzz 1 (offset -8 lines).
Hunk #4 succeeded at 133 with fuzz 2 (offset -13 lines).
Hunk #5 FAILED at 158.
Hunk #6 FAILED at 178.
Hunk #7 succeeded at 161 (offset -32 lines).
Hunk #8 succeeded at 216 (offset -34 lines).
3 out of 8 hunks FAILED -- saving rejects to file class_ldapFilter.inc.rej

By mhamant on 2018-09-21T10:14:22 (imported from GitLab)

created branch 5889-ldap-filter-parsing-issue

By Côme Chilliet on 2018-10-16T08:13:52 (imported from GitLab)

mentioned in merge request !424

By Côme Chilliet on 2018-10-16T08:13:59 (imported from GitLab)

mentioned in commit 98232fb2

By Côme Chilliet on 2018-10-16T08:18:04 (imported from GitLab)

changed milestone to %FusionDirectory 1.3

By Côme Chilliet on 2018-10-16T08:18:29 (imported from GitLab)

added Bronze label

By bmortier on 2018-10-29T16:01:02 (imported from GitLab)

hello @mhow2,

its better to test that on a 1.3-dev as 1.2.x is for minimal fixes only

Cheers

By bmortier on 2018-10-29T16:02:18 (imported from GitLab)

hello @mhow2,

did you got the time to test this on 1.3

Cheers

By bmortier on 2018-12-19T09:24:59 (imported from GitLab)

I'm sorry for the delay and in addition we had to implement a workaround in the meantime the issue was being fixed back in September. I can't test on 1.3 right now, but I can confirm the test we did in September by replacing class_ldapFilter.inc with the patched one fixed the issue. We have reproduced today, it seems to work as intended.

By mhamant on 2019-01-02T09:33:10 (imported from GitLab)

closed

By bmortier on 2019-01-02T10:17:46 (imported from GitLab)

added Fixed label

By Côme Chilliet on 2019-01-02T10:45:08 (imported from GitLab)