Review FD UI for disabled fields

The idea is to improve the UI of FusionDirectory when it’s used with a non-admin account, including:

1. When all fields are read-only
2. When only a few fields are readable/writable

Actual behavior

UI is the same as the admin with greyed-out fields for non-writable and non-readable fields

Expected behavior

Ideas:

1. Have a special class for form element which should only show for writable attributes, like the add/remove buttons on SetAttributes (easy to do for linearRendering=TRUE, but requires some coding/thinking for linearRendering=FALSE)
2. Have a special class for non-readable attributes, allowing to hide them completely
3. Alter CSS so that non-writable inputs are easy to read and not confusing (this means they need a special class as well be distinguishable from disabled fields)
4. Must star should be added by CSS, not smarty (not directly related but requires the same kind of code changes)

Difficulties

1. We need to avoid empty sections
2. Hiding/removing an empty section may mess the layout
3. Managed attributes may need to be exempted of these changes
4. When hiding an input we need to hide the label as well

added PJ1802-0188 label

By Côme Chilliet on 2018-07-16T13:43:33 (imported from GitLab)

added 2h of time spent at 2018-07-16

By Côme Chilliet on 2018-07-16T13:45:22 (imported from GitLab)

added PJ1804-0204 and removed PJ1802-0188 labels

By bmortier on 2018-07-17T08:10:10 (imported from GitLab)

added technical discussion label

By bmortier on 2018-08-31T14:19:48 (imported from GitLab)

mentioned in issue #5900

By Côme Chilliet on 2018-10-01T09:25:03 (imported from GitLab)

mentioned in commit bddf0fc9

By Côme Chilliet on 2018-10-17T15:22:11 (imported from GitLab)

added fusiondirectory-core label

By bmortier on 2018-10-29T16:09:03 (imported from GitLab)

changed due date to July 29, 2019

By bmortier on 2019-07-24T07:49:42 (imported from GitLab)

hello @MCMic,

lets do research work on this one as this is frequently asked and see if its possible. i agree you work 2/3 days on this and then we do a review of whats possible and not

Cheers

By bmortier on 2019-07-24T07:51:08 (imported from GitLab)

added 5m of time spent at 2019-07-24

By bmortier on 2019-07-24T07:51:08 (imported from GitLab)

mentioned in merge request !651

By Côme Chilliet on 2019-07-30T08:40:57 (imported from GitLab)

created merge request !651 to address this issue

By Côme Chilliet on 2019-07-30T08:41:04 (imported from GitLab)

mentioned in issue fd-plugins#5987 (closed)

By Côme Chilliet on 2019-07-30T10:05:13 (imported from GitLab)

mentioned in commit 47c9de3d

By Côme Chilliet on 2019-07-30T10:52:11 (imported from GitLab)

mentioned in commit acde5328

By Côme Chilliet on 2019-07-30T11:41:23 (imported from GitLab)

mentioned in commit 510c1ce9

By Côme Chilliet on 2019-07-30T14:21:10 (imported from GitLab)

mentioned in commit d296dc62

By Côme Chilliet on 2019-07-30T14:27:30 (imported from GitLab)

mentioned in commit cb04e143

By Côme Chilliet on 2019-07-30T14:33:30 (imported from GitLab)

So, here’s where we are so far:

This is the user list seen from a user which can only edit a few fields: The main thing to see here is that others tabs are hidden from the "Properties" column.

This is how user edition looks: Here you can see:

1. Tabs we cannot read are hidden
2. Fields we cannot read are hidden
3. Sections with no readable fields are hidden as well

This is how group edition looks: Here you can see:

1. Non writable fields hide add/remove buttons
2. Non writable fields have black text so you can still read them

As a comparison, here is what the admin would see for the same objects:

By Côme Chilliet on 2019-07-30T15:08:27 (imported from GitLab)

added 5h of time spent at 2019-07-30

By Côme Chilliet on 2019-07-30T15:10:33 (imported from GitLab)