Small weirdness in foreignKey handling
Small weirdness in foreignKey handling
Description
While working on #5799 I saw that there are some small weird things in foreignKey handling which might slow things down a bit
First one is some object types appear both as uppercase and lowercase in the $foreignRefs temp array instead of appearing only once (should be easy to fix).
Second one is that ACL assignment foreign keys appear both as from ACL assignment object type and each departement object type, which duplicate the LDAP search (harder to fix, might need a hardcoded special case for this tab).
FusionDirectory Version
1.3-dev
Steps to Reproduce
- Add a debug dump for $foreignKey temp array
- Go to the references tab of a user
- Look at the dump
Expected behavior:
Clean well-organized array
Actual behavior:
Some duplicated info and mixed upper/lower case for object types
Activity
created branch
5809-small-weirdness-in-foreignkey-handlingBy Côme Chilliet on 2018-04-03T13:58:29 (imported from GitLab)
mentioned in commit 5f875068
By Côme Chilliet on 2018-04-03T14:02:58 (imported from GitLab)
mentioned in commit 79f6767b
By Côme Chilliet on 2018-04-03T14:02:58 (imported from GitLab)
mentioned in commit 34a62899
By Côme Chilliet on 2018-04-03T14:02:58 (imported from GitLab)
mentioned in commit bac61b43
By Côme Chilliet on 2018-04-03T14:15:46 (imported from GitLab)
added PJ1802-0188 label
By bmortier on 2018-04-05T08:57:58 (imported from GitLab)
It appears than converting the objectTypes to uppercase where I did causes problems as it affects the case of automatic ACL categories which seem to be case sensitive. So this part needs to be done in another way or another place.
By Côme Chilliet on 2018-04-05T13:16:40 (imported from GitLab)
created branch
5809-small-weirdness-in-foreignkey-handlingBy Côme Chilliet on 2018-04-05T13:25:32 (imported from GitLab)
mentioned in commit 0ed7e74d
By Côme Chilliet on 2018-04-05T13:28:41 (imported from GitLab)
added Changed label
By bmortier on 2019-01-23T09:04:51 (imported from GitLab)
