FileAttribute through webservice should base64 encode binary data to avoid crashes

Description

When certain images are set as profile picture, the API no longer returns any data (At all).

Distribution Name and Version

Whatever demo.fusiondirectory.org runs on and Debian 8.

FusionDirectory Version

1.2

PHP version used

Whatever demo.fusiondirectory.org uses.

Origin of php packages

Whatever demo.fusiondirectory.org uses.

Steps to Reproduce

1. Set image fd_non_working_image.jpg (Supplied) as account image for a user.
2. Get data for user using the method getfields() in the API.
3. Observe nothing beeing returned by the API.

Expected behavior:

User's data should be returned.

Actual behavior:

No data is returned.

Reproduces how often:

100%

Additional Information

Bug observed on both own installation of FD1.2 and demo.fusiondirectory.org.

Behavior is dependent on the image. Only some (like the attached) jpeg files reveal the bug.

changed the description

By tbp on 2018-03-22T11:48:53 (imported from GitLab)

assigned to @MCMic

By bmortier on 2018-03-22T12:36:33 (imported from GitLab)

changed milestone to %FusionDirectory 1.3

By bmortier on 2018-03-22T12:36:38 (imported from GitLab)

mentioned in issue fd-plugins#5796 (closed)

By Côme Chilliet on 2018-03-22T16:47:51 (imported from GitLab)

Had a hard time to get an error message but I finally got it (see fd-plugins#5796 (closed) ). So the problem is:

Request error: Failed to encode response: Malformed UTF-8 characters, possibly incorrectly encoded

So I guess depending of the content of the image it can contain stuff which cannot be encoded as a json string as-is. This means we need to rethink how fileattribute get serialized. Should we use base64? Should we just omit them and add an other method to get the value, just in case the value is too big?

By Côme Chilliet on 2018-03-22T16:50:27 (imported from GitLab)

The image that triggers this bug, was made with theis Python library (PIL): http://www.pythonware.com/products/pil/

It's possible, there could be a bug in PIL.

No matter what the cause is, FD should return something if faced with such an image.

By tbp on 2018-03-23T08:29:45 (imported from GitLab)

added PJ1802-0188 label

By bmortier on 2018-03-26T08:26:55 (imported from GitLab)

created branch 5802-some-jpeg-images-break-the-api

By Côme Chilliet on 2018-03-26T12:29:28 (imported from GitLab)

mentioned in merge request !181

By Côme Chilliet on 2018-03-26T12:29:30 (imported from GitLab)

mentioned in commit fe67e0c4

By Côme Chilliet on 2018-03-26T12:30:59 (imported from GitLab)

added 1h of time spent at 2018-03-26

By Côme Chilliet on 2018-03-26T12:50:46 (imported from GitLab)

added To Be Tested label

By Côme Chilliet on 2018-03-26T12:50:46 (imported from GitLab)

removed Bugs label

By bmortier on 2018-03-30T16:50:49 (imported from GitLab)

Tested on demo-dev and getfields return something now

By Jonathan Swaelens on 2018-07-05T09:39:32 (imported from GitLab)

closed

By Jonathan Swaelens on 2018-07-05T09:39:33 (imported from GitLab)

added 40m of time spent at 2018-07-05

By Jonathan Swaelens on 2018-07-05T09:39:35 (imported from GitLab)

added Fixed and removed To Be Tested labels

By Jonathan Swaelens on 2018-07-05T09:39:35 (imported from GitLab)

changed title from Some jpeg images break the API to FileAttribute through webservice should base64 encode binary data to avoid crashes

By Côme Chilliet on 2018-07-19T13:26:57 (imported from GitLab)

added Changed and removed Fixed labels

By Côme Chilliet on 2018-07-19T13:27:11 (imported from GitLab)