Unclear LDAP errors when DN creation fails
Unclear LDAP errors when DN creation fails
Description
i have an installation with the audit plugin installed, an regulary a get this a the end of a delete of objects or cancel of a template.
La requête LDAP a échoué !
Objet: none
Erreur: Invalid DN syntax (invalid DN, lors de l'opération sur 'none' en utilisant le serveur LDAP 'ldaps://ldap1-test.campus-condorcet.fr')
Distribution Name and Version
Debian stretch
FusionDirectory Version
1.2-fixes
PHP version used
PHP 7.0.27-0+deb9u1 (cli) (built: Jan 5 2018 13:51:52) ( NTS ) Copyright (c) 1997-2017 The PHP Group Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies with Zend OPcache v7.0.27-0+deb9u1, Copyright (c) 1999-2017, by Zend Technologies
Origin of php packages
Debian stretch
Steps to Reproduce
Not easy to repoduced but happen in certain ocassion, like cancel an apply template, end of a delete or move
Expected behavior:
No error show be happening
Actual behavior:
Get a red alert message
La requête LDAP a échoué !
Objet: none
Erreur: Invalid DN syntax (invalid DN, lors de l'opération sur 'none' en utilisant le serveur LDAP 'ldaps://ldap1-test.campus-condorcet.fr')
Reproduces how often:
30% time
Additional Information
Activity
added Bug in version:1.2 label
By bmortier on 2018-03-22T12:39:42 (imported from GitLab)
Found the source: When create_unique_dn fails, it returns "none".
So it means that audit is creating an object but cannot find any unique combination of fields to use for the DN. That means at the same date and time the same action by the same user was logged twice.
We need at least to change this 'none' behavior and make sure to show a proper error in this case. But also we need to look into how this can happen and if maybe the audit should just ignore the error in this case.
By Côme Chilliet on 2018-03-27T09:33:56 (imported from GitLab)
created branch
5800-in-certain-occasion-like-cancel-an-apply-template-end-of-a-delete-or-move-i-got-an-ldap-errorBy Côme Chilliet on 2018-03-27T10:00:35 (imported from GitLab)
mentioned in commit 8ee44b68
By Côme Chilliet on 2018-03-27T10:02:25 (imported from GitLab)
added fixes label
By Côme Chilliet on 2018-03-29T09:26:01 (imported from GitLab)
added fixes-merged and removed fixes labels
By Côme Chilliet on 2018-03-29T09:42:46 (imported from GitLab)
changed milestone to %FusionDirectory 1.2.1
By Côme Chilliet on 2018-04-03T12:41:02 (imported from GitLab)
added Fixed label
By Côme Chilliet on 2018-04-03T12:41:37 (imported from GitLab)
mentioned in issue fd-plugins#5802 (closed)
By Côme Chilliet on 2018-04-03T12:45:20 (imported from GitLab)
