When we rename a department foreignKeys on subobjects DN are not updated

Description

When we rename a department the user get correctly moved but the group still keep the old dn in the member list.

Distribution Name and Version

Debian stretch

FusionDirectory Version

1.2-fixes

PHP version used

PHP 7.0.27-0+deb9u1 (cli) (built: Jan 5 2018 13:51:52) ( NTS ) Copyright (c) 1997-2017 The PHP Group Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies with Zend OPcache v7.0.27-0+deb9u1, Copyright (c) 1999-2017, by Zend Technologies

Origin of php packages

Debian stretch

Steps to Reproduce

1. Rename the department from external to external-2
2. Open the group and look at the list
3. I see dn: unknow uid=bmortier,xxx
4. rename the department back to external
5. Open the group and look at the list
6. I see the correct dn for bmortier

Expected behavior:

The list should reflect the user correctly even when the department is renamed/moved

Actual behavior:

You get an unknow uid=bmortier,xxx

Reproduces how often:

100% time

Additional Information

mentioned in issue #5796 (closed)

By bmortier on 2018-03-20T16:18:29 (imported from GitLab)

added 10m of time spent at 2018-03-20

By bmortier on 2018-03-20T16:18:39 (imported from GitLab)

changed title from When we rename a department the user got correctly renamed but the group still keep the old reference in the display list. to When we rename a department foreignKeys on subobjects DN are not updated

By Côme Chilliet on 2018-03-20T16:21:11 (imported from GitLab)

changed the description

By Côme Chilliet on 2018-03-20T16:21:11 (imported from GitLab)

My first thought on this was it would be too long/complicated to find all objects in a departement and guess their types to see if they have references on them. But as a departement move can only affect the DN of the subentries, maybe we could find a way to call foreignKeyUpdate (or an other special method) on all objects having references on DNs.

Basically the goal would be to search for member=*olddepartementdn for instance for object groups member foreignKey. Optimisation will have to be taken care of.

By Côme Chilliet on 2018-04-03T08:33:38 (imported from GitLab)

added 10m of time spent at 2018-03-20

By Côme Chilliet on 2018-03-20T16:25:16 (imported from GitLab)

added Bugs label

By Côme Chilliet on 2018-03-20T16:27:59 (imported from GitLab)

added ~590 label

By bmortier on 2018-03-22T12:40:21 (imported from GitLab)

mentioned in issue #5809

By Côme Chilliet on 2018-04-03T11:51:58 (imported from GitLab)

created branch 5799-when-we-rename-a-department-foreignkeys-on-subobjects-dn-are-not-updated

By Côme Chilliet on 2018-04-04T14:41:34 (imported from GitLab)

mentioned in merge request !200

By Côme Chilliet on 2018-04-04T14:41:35 (imported from GitLab)

mentioned in commit fb429a9f

By Côme Chilliet on 2018-04-04T14:43:14 (imported from GitLab)

mentioned in commit 35fe0466

By Côme Chilliet on 2018-04-04T14:56:06 (imported from GitLab)

added 1d 1h of time spent at 2018-04-04

By Côme Chilliet on 2018-04-04T15:19:39 (imported from GitLab)

created branch 5799-when-we-rename-a-department-foreignkeys-on-subobjects-dn-are-not-updated

By Côme Chilliet on 2018-04-05T08:28:43 (imported from GitLab)

mentioned in merge request !201

By Côme Chilliet on 2018-04-05T08:28:44 (imported from GitLab)

mentioned in commit ce84f420

By Côme Chilliet on 2018-04-05T08:35:59 (imported from GitLab)

mentioned in commit 5737fab7

By Côme Chilliet on 2018-04-05T08:36:00 (imported from GitLab)

created branch 5799-when-we-rename-a-department-foreignkeys-on-subobjects-dn-are-not-updated

By Côme Chilliet on 2018-04-05T10:14:11 (imported from GitLab)

mentioned in merge request !202

By Côme Chilliet on 2018-04-05T10:14:12 (imported from GitLab)