No defined variables in hook SnapshotCreateDialog

Description

In the case you need a hook when snapshoting an account for example, only one action is called : "check"

Unfortunately this hooks isn't giving any variables on the snapshot object, except those about the CALLER

Distribution Name and Version

• Debian 8

FusionDirectory Version

fusiondirectory/stable,now 1.2-1 all  [installé]
  Web Based LDAP Administration Program

PHP version used

$ php -v
PHP 5.6.33-0+deb8u1 (cli) (built: Jan  5 2018 16:30:14)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2016, by Zend Technologies

Origin of php packages

Debian

Steps to Reproduce

1. Create a hooks which expose the arguments and exit with 1
2. Call this hook on object SnapshotCreateDialog whith action check" with command /path_to_hooks/test %object_dn% %timestamp% %description%
3. Check the case show the hook result
4. Launch a snapshot on one user

Expected behavior:

1. An alert with at least the variable %object_dn% with the dn of the object of the snapshot

Actual behavior:

1. The alert will show that none of the variables are present

Reproduces how often:

Every time

Additional Information

• You can check the SnapshotCreateDialog here
• And the check public function, inherited from class simplePlugins : direct access to function check

changed title from Defined variables in hook SnapshotCreateDialog to No defined variables in hook SnapshotCreateDialog

By jAvond Jerome on 2018-01-29T13:29:06 (imported from GitLab)

changed the description

By jAvond Jerome on 2018-01-29T13:31:11 (imported from GitLab)

assigned to @MCMic

By Côme Chilliet on 2018-01-29T13:34:23 (imported from GitLab)

changed milestone to %FusionDirectory 1.4

By Côme Chilliet on 2018-01-29T13:34:26 (imported from GitLab)

added Bugs ~593 labels

By Côme Chilliet on 2018-01-29T13:34:53 (imported from GitLab)

Ok, looking for this line

You can have access to this variable : %nbCheckErrors%

So there is a need of either :

• redefine the check() function to catch attributes of the inherited class which call
• Create a check() function in class SnapshotCreateDialog with the good attributes

By jAvond Jerome on 2018-01-29T13:37:45 (imported from GitLab)

added PJ1802-0188 label

By bmortier on 2018-03-17T21:27:52 (imported from GitLab)

changed due date to June 06, 2019

By bmortier on 2019-06-04T12:10:43 (imported from GitLab)

hello @MCMic,

whats your idea about this proposal ?

Cheers

By bmortier on 2019-06-04T12:11:12 (imported from GitLab)

added 5m of time spent at 2019-06-04

By bmortier on 2019-06-04T12:11:12 (imported from GitLab)

removed Bugs label

removed due date

By bmortier on 2019-06-06T12:43:30 (imported from GitLab)

changed due date to June 13, 2019

By bmortier on 2019-06-06T12:43:32 (imported from GitLab)

created merge request !613 to address this issue

By Côme Chilliet on 2019-06-20T15:13:27 (imported from GitLab)

mentioned in merge request !613

By Côme Chilliet on 2019-06-20T15:13:27 (imported from GitLab)

mentioned in commit d021b4e0

By Côme Chilliet on 2019-06-20T15:15:08 (imported from GitLab)

added 1h of time spent at 2019-06-20

By Côme Chilliet on 2019-06-20T15:16:05 (imported from GitLab)

added To Be Tested label

assigned to @jswaelens and unassigned @MCMic

By Côme Chilliet on 2019-06-20T15:16:08 (imported from GitLab)

assigned to @MCMic and unassigned @jswaelens

By bmortier on 2019-06-27T14:20:27 (imported from GitLab)