FIXME legacy code should be removed from callHook method

There is an ugly piece of code with this comment in plugin::callHook:

// If there are still some %.. in our command, try to fill these with some other class vars (FIXME: useless)

The code seems dangerous and may be slow in some cases. We should remove it and just need to check that vars such as the base stays availables.

(from redmine: issue id 5041, created on 2016-08-02, closed on 2017-02-09)

• Changesets:
  • Revision 57af1805 on 2016-08-02T13:27:09.000Z:

Fixes #5041 Removed legacy code from callHook method

Added base as a special case. Others might be added later if needed.

• Custom Fields:
  • Bug in version: 1.0.14

I added a selenium test for hook which test access to base, callerDN and callerUID, it works fine.

Close issue

(from redmine: written on 2017-02-09)

By Côme Chilliet on 2017-09-02T15:32:30 (imported from GitLab)

closed

By Côme Chilliet on 2017-09-02T15:32:31 (imported from GitLab)

added Changed label

By bmortier on 2018-09-24T14:09:42 (imported from GitLab)

removed Bugs label

added PJ1802-0188 fusiondirectory-core labels