Skip to content
GitLab
Closed
Issue created by bmortier@bmortierMaintainer

No upper case characters allowed in group-names

Closed

No upper case characters allowed in group-names

For better readability the group names should be allowed Upper-case characters. From within LDAP it really does not matter. I have groups with upper case letters up and running fine.

How to reproduce:

  • Log in to FD and navigate to "Groups and Roles"
  • Try to add or modify a group and set the name to contain some upper-case characters (e.g. "Linux-Login" for users allowed to login to linux)
  • when saving or applying you get this message: "The field 'Name' contains invalid characters. 'LS' are not allowed!"

(from redmine: issue id 5005, created on 2016-07-13, closed on 2016-09-27)

  • Changesets:
    • Revision 73c255e3 by Côme Chilliet on 2016-09-26T07:44:38.000Z:
Fixes #5005 Allowing uppercase in group names if strict mode is disabled
  • Revision 244e8e71 by Côme Chilliet on 2016-09-26T07:45:36.000Z:
Fixes #5005 Allowing uppercase in group names if strict mode is disabled
  • Custom Fields:
    • Bug in version: 1.0.14

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Activity

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      hello,

      yes but you can't mix both, so the convention in fusiondirectory is lowercase everywhere when in strict mode is enabled.

      Cheers

      (from redmine: written on 2016-07-13)

      By bmortier on 2017-09-02T15:31:47 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      You need to uncheck the option «Strict naming policy» in the configuration to allow uppercase in users logins and groups names.

      (from redmine: written on 2016-07-27)

      By Côme Chilliet on 2017-09-02T15:31:47 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Hi Côme,

      i unchecked the option in "people and group storage" on the config-page, saved and tried to create a group named "TestGroup".

      The error comes again:

      The field 'Name' contains invalid characters. 'TG' are not allowed! "TestGroup"

      So that does not do the trick, sorry.

      Greets Thomas

      EDIT: But I can live with that if it causes FD to be more stable.

      (from redmine: written on 2016-07-27)

      By tniercke on 2017-09-02T15:31:47 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Thomas Niercke wrote:

      So that does not do the trick, sorry.

      Indeed I checked and uppercase is forbidden even in non-strict mode, I’m not sure why

      EDIT: But I can live with that if it causes FD to be more stable.

      It’s always better to keep FD in strict mode and use lowercase for things like logins and group names.

      (from redmine: written on 2016-07-28)

      By Côme Chilliet on 2017-09-02T15:31:47 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      ok, so on my behalf the ticket may be closed.

      (from redmine: written on 2016-08-01)

      By tniercke on 2017-09-02T15:31:48 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Close issue

      (from redmine: written on 2016-08-02)

      By bmortier on 2017-09-02T15:31:48 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Hello,

      I had the same problem. I did something unorthodox but now upper case characters in group-name works.

      The plugins where groups are inserted are in:

      • fussiondirectory/plugins/admin/groups/class_group.inc (line 62 in fd version 1.0.14-1)
      • fussiondirectory/plugins/admin/groups/class_ogroup.inc (line 195 in fd version1.0.14-1)

      I emphasize the line number and fd version for every file because at them there is a regexp which validate the introduced characters so I just added 'A-Z' in both files and now it work.

      Here you have StringAttribute object document to understand a bit more about simplePlugin

      (from redmine: written on 2016-08-04)

      By imartinez on 2017-09-02T15:31:49 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      I have the same issue, even in non strict mode, groups can't have uppercase. I don't understand why the issue is closed, it does not seem to be fixed on 1.0.15.

      (from redmine: written on 2016-09-22)

      By coudot on 2017-09-02T15:31:49 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Reopen issue

      (from redmine: written on 2016-09-22)

      By bmortier on 2017-09-02T15:31:50 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      hello,

      it was closed because the user was happy the way it was after my explanation :) but i agree in non sctrict mode it should be allowed, however it must be correctly tested because mixing upper and non upper case of the exactly same group have funny effect :)

      Cheers

      (from redmine: written on 2016-09-25)

      By bmortier on 2017-09-02T15:31:51 (imported from GitLab)

    • bmortier
      bmortier @bmortier ·
      Author Maintainer

      Close issue

      (from redmine: written on 2016-09-27)

      By bmortier on 2017-09-02T15:31:51 (imported from GitLab)

    • bmortier closed

      closed

      By bmortier on 2017-09-02T15:31:48 (imported from GitLab)

    • bmortier reopened

      reopened

      By bmortier on 2017-09-02T15:31:50 (imported from GitLab)

    • bmortier closed

      closed

      By bmortier on 2017-09-02T15:31:51 (imported from GitLab)

    • bmortier added Fixed label

      added Fixed label

      By bmortier on 2018-09-27T19:24:14 (imported from GitLab)

    Please register or sign in to reply