Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory fusiondirectory
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 34
    • Issues 34
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectory
  • fusiondirectoryfusiondirectory
  • Issues
  • #4652
Closed
Open
Created Mar 24, 2016 by Côme Chilliet@cchillietReporter

The weird _copy fallback should be removed

The move method in plugin class calls rename, if rename fails it calls copy and then ldap->rmdir_recursive. This copy method calls copy, which contains weird code calling directly ldap* methods and using a plugin::rebind method which seems wrong (the array key used are the wrong ones).

We should remove this whole fallback mechanism, if ldap_rename fails the rename should fail and the admin needs to fix the LDAP server.

(from redmine: issue id 4652, created on 2016-03-24, closed on 2016-04-04)

  • Changesets:
    • Revision 3e4d2e0c by Côme Chilliet on 2016-03-24T10:50:16.000Z:
Fixes #4652 Remove the fallback mechanism of rename
  • Revision 9ca02056 by Côme Chilliet on 2016-03-24T10:51:26.000Z:
Fixes #4652 Remove the fallback mechanism of rename
  • Custom Fields:
    • Bug in version: 1.0.10
Assignee
Assign to
Time tracking