list of group membership in user when in mixed mode 1.0.9x is not showing the same info as in 1.0.8.9

it used to be "groupid [group desc]"

it is now "$groupid" which is quite ugly for final users

(from redmine: issue id 4208, created on 2015-10-10, closed on 2015-10-12)

• Relations:
  • copied_to #4194 (closed)
• Changesets:
  • Revision 1564d2a6 by Côme Chilliet on 2015-10-12T07:34:36.000Z:

Fixes #4208 Added descriptions to groups and roles list in user tab

• Revision 4d6911b1 by Côme Chilliet on 2015-10-12T07:42:24.000Z:

Fixes #4208 Truncating description at 50 chars if needed

• Revision ce611555 by Côme Chilliet on 2015-10-12T07:43:14.000Z:

Fixes #4208 Added descriptions to groups and roles list in user tab

• Revision c7940f76 by Côme Chilliet on 2015-10-12T07:43:27.000Z:

Fixes #4208 Truncating description at 50 chars if needed

• Custom Fields:
  • Bug in version: 1.0.9
• Uploads:
  • 

A patch to fix the problem can be found here:

https://github.com/makinacorpus/corpus-fusiondirectory/blob/master/.salt/files/patches/usergroupname.patch

(from redmine: written on 2015-10-10)

By kiorky on 2017-09-02T15:24:50 (imported from GitLab)

I’ve put the cn first and the description between brackets as it seems more logic. The description will get truncated to 50 chars if it’s longer to avoid weird things with long descriptions.

I’ve also made the same modification for roles to be consistent.

(from redmine: written on 2015-10-12)

By Côme Chilliet on 2017-09-02T15:24:50 (imported from GitLab)

Nope, description should go first (as it was before). cn is mainly technical, and is secondary for end users.

(from redmine: written on 2015-10-12)

By kiorky on 2017-09-02T15:24:51 (imported from GitLab)

Having description first would break consistency when there is no description. Plus description can be quite long, and is a description. The cn is the name of the group.

(from redmine: written on 2015-10-12)

By Côme Chilliet on 2017-09-02T15:24:51 (imported from GitLab)

Can you please read carefully the patch, it handles the empty description.

(from redmine: written on 2015-10-12)

By kiorky on 2017-09-02T15:24:51 (imported from GitLab)

Mathieu Le Marec - Pasquet wrote:

Can you please read carefully the patch, it handles the empty description.

Exactly, in case of empty description, it puts the cn first, that breaks consistency, the first thing can be a description or a cn, depending on whether there is something between brackets afterwards.

(from redmine: written on 2015-10-12)

By Côme Chilliet on 2017-09-02T15:24:52 (imported from GitLab)

Without brackets in case of a missing description, which is intuitive and the oldier behavior, we must only see the CN (or a new configurable computed label defaulting to %cn)

This is also the regular behavior in a lot of ldap frontends (desc [uid] if we have desc or UID in other cases)

(from redmine: written on 2015-10-12)

By kiorky on 2017-09-02T15:24:52 (imported from GitLab)

hello,

looking at latest code, it show the name of the group and after the description if there is one. This look fine to me.

Cheers

(from redmine: written on 2015-10-12)

By bmortier on 2017-09-02T15:24:52 (imported from GitLab)

Close issue

(from redmine: written on 2015-10-12)

By bmortier on 2017-09-02T15:24:53 (imported from GitLab)

closed as unfixed, great. We will maintain our fork.

(from redmine: written on 2015-10-12)

By kiorky on 2017-09-02T15:24:54 (imported from GitLab)

Mathieu Le Marec - Pasquet wrote:

closed as unfixed, great. We will maintain our fork.

The description of the bug says «it used to be "groupid [group desc]"» It is now exactly displayed like this, see the attached screenshot.

(from redmine: written on 2015-10-12)

By Côme Chilliet on 2017-09-02T15:24:54 (imported from GitLab)

I wont continue this troll, this is using CN with all the downside explained on irc.

(from redmine: written on 2015-10-12)

By kiorky on 2017-09-02T15:24:54 (imported from GitLab)

closed

By bmortier on 2017-09-02T15:24:53 (imported from GitLab)

added Added label

By bmortier on 2018-10-05T15:04:42 (imported from GitLab)