Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory fusiondirectory
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectoryfusiondirectory
  • Issues
  • #4194
Something went wrong while setting issue due date.
Closed
Open
Issue created 9 years ago by bmortier@bmortierMaintainer
  • New related issue

  • New related issue

list of users membership in group when in mixed mode 1.0.9x is not showing the same info as in 1.0.8.9

Closed

list of users membership in group when in mixed mode 1.0.9x is not showing the same info as in 1.0.8.9

it used to be "$sn, $givenname (uid)"

it is now "uid (uid) which is quite ugly for final users

(from redmine: issue id 4194, created on 2015-10-09, closed on 2015-10-12)

  • Relations:
    • copied_to #4208
  • Changesets:
    • Revision fe535ba8 by Côme Chilliet on 2015-10-12T08:11:52.000Z:
Fixes #4194 Using nameAttr and not mainAttr for display
  • Revision 87165663 by Côme Chilliet on 2015-10-12T08:12:48.000Z:
Fixes #4194 Using nameAttr and not mainAttr for display
  • Custom Fields:
    • Bug in version: 1.0.9

    Tasks

    0
    Cannot read properties of undefined (reading 'workItem')

    Linked items
    0

    Link issues together to show that they're related. Learn more.

    Activity


    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      .

      (from redmine: written on 2015-10-09)

      By kiorky on 2017-09-02T15:24:30 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      The following patch can be applied to fix the problem:

      https://github.com/makinacorpus/corpus-fusiondirectory/blob/master/.salt/files/patches/groupusername.patch

      (from redmine: written on 2015-10-10)

      By kiorky on 2017-09-02T15:24:30 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      Can you try instead of this patch to just replace «mainAttr» by «nameAttr». If I recall correctly nameAttr is always cn for users (while mainAttr is what is used in dns)

      (from redmine: written on 2015-10-12)

      By Côme Chilliet on 2017-09-02T15:24:30 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      See the patch, the refactoral has sniped out a lot of code, specially on groups and users display, leaving out only cn (or uid). Replacing by nameAttr wont change a thing

      (from redmine: written on 2015-10-12)

      By kiorky on 2017-09-02T15:24:30 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      Mathieu Le Marec - Pasquet wrote:

      See the patch, the refactoral has sniped out a lot of code, specially on groups and users display, leaving out only cn (or uid). Replacing by nameAttr wont change a thing

      It will change. mainAttr is what is used in the dn, in your case uid. It’s not what should be displayed. nameAttr is what should be displayed, the cn in the case of users.

      If you set your cn pattern to «%sn%, %givenName%», I think you should get the same result as with you patch. I pushed the change to nameAttr as it is needed any way (if not for users then for other object types). You can test the git version and report any problem.

      (from redmine: written on 2015-10-12)

      By Côme Chilliet on 2017-09-02T15:24:30 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      As already explained on IRC, i can't change the CN to something else for organizational purpose.

      If i change the pattern, i also have to migrate the data (which is not a big deal, this is not the problem).

      On other hand, this was the behavior for ages to have $lastname, $firstname [uid], which is now changed, and can be considered as a non documented break.

      If you want not to ardcode a label here, the only solution i see is to have a specific and configurable pattern for group and user display on those specific pages. (this label would have to default to lastname,firstname [uid], of course.)

      The meaning is different on those pages.

      (from redmine: written on 2015-10-12)

      By kiorky on 2017-09-02T15:24:31 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      hello,

      the latest fixes show the value correctly for me so i'am closing this one

      Cheers

      Close issue

      (from redmine: written on 2015-10-12)

      By bmortier on 2017-09-02T15:24:31 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      Mathieu Le Marec - Pasquet wrote:

      As already explained on IRC, i can't change the CN to something else for organizational purpose.

      If i change the pattern, i also have to migrate the data (which is not a big deal, this is not the problem).

      If it is not a big deal, you should do this as FD relies on the CN for several other things and will continue to do so in the future

      On other hand, this was the behavior for ages to have $lastname, $firstname [uid], which is now changed, and can be considered as a non documented break. This is just a question of how things are displayed, it does not break anything. There are a lot of changes like this in each FD release as we tend to uniform things and use the new internal tools in every plugin.

      If you want not to hardcode a label here, the only solution i see is to have a specific and configurable pattern for group and user display on those specific pages. This is exactly the purpose of the CN field in FD and this is why you can now easily change its pattern in the «CN pattern» field of the configuration. We want the display of users to be consistent across pages and do not want a specific pattern for each page.

      (from redmine: written on 2015-10-12)

      By Côme Chilliet on 2017-09-02T15:24:32 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 9 years ago
      Author Maintainer

      closed as unfixed, great. We will maintain our fork.

      (from redmine: written on 2015-10-12)

      By kiorky on 2017-09-02T15:24:32 (imported from GitLab)

    • bmortier closed 7 years ago

      closed

      By bmortier on 2017-09-02T15:24:31 (imported from GitLab)

    • bmortier added Fixed label 6 years ago

      added Fixed label

      By bmortier on 2018-10-05T15:00:01 (imported from GitLab)

    Please register or sign in to reply
    Assignee
    bmortier's avatar
    bmortier
    Assign to
    Labels
    0
    None
    0
    None
      Assign labels
    • Manage project labels

    Milestone
    No milestone
    None
    Due date
    None
    None
    None
    Time tracking
    No estimate or time spent
    Confidentiality
    Not confidential
    Not confidential

    You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

    Lock issue
    Unlocked
    0
    0 Participants
    Reference:

    Menu

    Explore Projects Groups Topics Snippets