We need to clarify role situation

Hello,

Roles should be a core plugin as it's implementation of organizationalRole which is in openldap core schema. We need to know which applications reads organizationalRole nodes and fill the documentation, so that we understand better what the need is. The role plugin should use foreignKey so that we can remove all the role specific code.

Also, maybe merging aclRole and role is a good idea, not sure about that.

(from redmine: issue id 2901, created on 2013-12-12, closed on 2014-04-28)

• Relations:
  • copied_to #3099
  • copied_to #3182
• Changesets:
  • Revision bd6eb672 by Côme Chilliet on 2014-04-24T13:39:33.000Z:

Fixes #2901 Moved roles into groupManagement

• Revision ee7b83d5 by Côme Chilliet on 2014-06-25T12:49:31.000Z:

Fixes #2901 Moved roles into groupManagement

Conflicts:
	plugins/admin/groups/class_groupManagement.inc
	plugins/personal/generic/class_user.inc

• Custom Fields:
  • Bug in version: 1.0.7.3
• Uploads:
  • 0001-Fixes-2901-Moved-roles-into-groupManagement.patch

About merging role and aclRole, it's a bad idea because aclRoles are assigned for a given subtree while roles are assigned directly to users.

(from redmine: written on 2013-12-17)

By Côme Chilliet on 2017-09-02T15:07:14 (imported from GitLab)

Hello,

yes..

i think we should close this ticket

Cheers

(from redmine: written on 2013-12-17)

By bmortier on 2017-09-02T15:07:14 (imported from GitLab)

Why? The role situation is still unresolved.

We need to decide wether to keep it or not, wether to include it in core or not, wether to include it in groupManagement or to keep it in its own management class, and we need to replace code which is specific to him by clean foreignKey information.

(from redmine: written on 2013-12-17)

By Côme Chilliet on 2017-09-02T15:07:14 (imported from GitLab)

Hello,

sorry i overlook the real start of the ticket :)

i will made some thinking and reading during the holidays

cheers

(from redmine: written on 2013-12-17)

By bmortier on 2017-09-02T15:07:15 (imported from GitLab)

hello,

after looking at what it does and how it save its data, i recommend the following

• keep it
• move it into core
• move it into group management with a dropdown in the menu saying Create->"Roles"
• clean foreign key implementation

Cheers

(from redmine: written on 2014-04-22)

By bmortier on 2017-09-02T15:07:15 (imported from GitLab)

I just push selenium tests for the foreign keys.

(from redmine: written on 2014-04-25)

By Jonathan Swaelens on 2017-09-02T15:07:16 (imported from GitLab)

Role creation and edition work.

Close issue

(from redmine: written on 2014-04-28)

By Jonathan Swaelens on 2017-09-02T15:07:16 (imported from GitLab)

closed

By Jonathan Swaelens on 2017-09-02T15:07:16 (imported from GitLab)

added Changed label

By bmortier on 2018-10-15T12:06:05 (imported from GitLab)