The code should follow code guidelines

Now that we can measure it : https://bisi-build.ibcp.fr/sonar/ we should adapt the code so that code guidelines are followed.

(from redmine: issue id 2595, created on 2013-08-01, closed on 2015-05-05)

• Relations:
  • duplicates #2397 (closed)
  • precedes #2567 (closed)
  • precedes #2555 (closed)
  • precedes #2554 (closed)
  • precedes #2553 (closed)
  • precedes #2552 (closed)
  • precedes #2549 (closed)
  • precedes #2544 (closed)
  • copied_to #2410
• Changesets:
  • Revision c0832870 by Côme Chilliet on 2013-08-01T17:33:26.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 9d25168d by Côme Chilliet on 2013-08-01T17:33:34.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 6177ad6b by Côme Chilliet on 2013-08-02T08:01:48.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 79bb6a14 by Côme Chilliet on 2013-08-02T09:55:31.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision db47a04f by Côme Chilliet on 2013-08-02T14:57:18.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 1140e799 by Côme Chilliet on 2013-08-08T08:46:22.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 72e03940 by Côme Chilliet on 2013-08-08T13:20:46.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 913a0a3f by Côme Chilliet on 2013-08-12T08:55:00.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision afe590ed by Côme Chilliet on 2013-08-12T11:24:08.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 98a2ecbc by Côme Chilliet on 2013-08-12T14:36:21.000Z:

Fixes: #2595 Clean objectSelect and fixed tabs_ogroup

• Revision 18e6af96 by Côme Chilliet on 2013-08-14T15:17:58.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 8fdf264d by Côme Chilliet on 2013-08-16T07:55:24.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 5b2a7729 by Côme Chilliet on 2013-08-19T13:19:44.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision dc827688 by Côme Chilliet on 2013-09-16T17:32:53.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision bd49e8f9 by Côme Chilliet on 2013-09-16T17:35:22.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 88572b4c by Côme Chilliet on 2013-09-16T17:45:49.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision f5dfec63 by Côme Chilliet on 2013-09-20T15:38:07.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 3dc68d99 by Côme Chilliet on 2013-09-20T15:52:52.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 16159bb9 by Côme Chilliet on 2013-09-20T15:53:05.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 0bfb5bf2 by Côme Chilliet on 2013-09-20T16:51:39.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision f9fb5813 by Côme Chilliet on 2013-09-20T16:53:33.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 1e550ec2 by Côme Chilliet on 2013-09-20T18:02:30.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 36855bc4 by Côme Chilliet on 2013-09-20T18:08:31.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 2bfb3d16 by Côme Chilliet on 2013-09-21T10:56:18.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 90b306a5 by Côme Chilliet on 2013-09-21T11:10:31.000Z:

Fixes: #2595 The code should follow code guidelines

• Revision 6f2ce708 by Côme Chilliet on 2013-12-11T11:05:58.000Z:

Fixes: #2595 Removed some duplicated blocks

• Revision 52a6f400 by Côme Chilliet on 2013-12-11T12:32:01.000Z:

Fixes: #2595 Removed some duplicated blocks

• Revision ab83d235 by Côme Chilliet on 2013-12-11T16:07:45.000Z:

Fixes: #2595 Cleaning some code

• Revision d7c94fc4 by Benoit MORTIER on 2013-12-12T08:50:19.000Z:

Fixes: #2595 Cleaning some code

• Revision 67664882 by Côme Chilliet on 2013-12-17T18:03:34.000Z:

Fixes: #2595 cleaning files in include folder

• Revision 30779140 by Côme Chilliet on 2013-12-17T18:03:49.000Z:

Fixes: #2595 cleaning files in include folder

• Revision 9e6fe4fe by Côme Chilliet on 2013-12-18T08:46:05.000Z:

Fixes: #2595 Some code cleaning

• Revision f3891925 by Côme Chilliet on 2013-12-18T08:46:22.000Z:

Fixes: #2595 Some code cleaning

• Revision 677a1c94 by Côme Chilliet on 2013-12-19T12:47:05.000Z:

Fixes: #2595 Using __construct to call plugin constructor

• Revision 51379dbf by Côme Chilliet on 2013-12-19T12:47:15.000Z:

Fixes: #2595 Using __construct in plugin

• Revision ace24a04 by Côme Chilliet on 2013-12-19T12:47:32.000Z:

Fixes: #2595 Using __construct in plugin

• Custom Fields:
  • Bug in version: 1.0.5
• Uploads:
  • 0001-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0002-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0003-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0004-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0005-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0006-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0007-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0008-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 0009-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 00010-Fixes-2595-Clean-objectSelect-and-fixed-tabs_ogroup.patch
  • 00011-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 00012-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 00013-Fixes-2595-The-code-should-follow-code-guidelines.patch
  • 00014-Fixes-an-error-from-commit-79bb6a14.patch
  • 00015-Fixes-2595-Removed-some-duplicated-blocks.patch
  • 00016-Fixes-2595-Cleaning-some-code.patch
  • conflict-2595-1.0.8.txt
  • 00017-Fixes-2595-cleaning-files-in-include-folder.patch
  • 00018-Fixes-2595-Some-code-cleaning.patch
  • 00019-Fixes-2595-Using-__construct-to-call-plugin-construc.patch
  • 00020-Fixes-2595-Using-__construct-in-plugin.patch

This clean a bit plugin hook code and acl sorting method but it should work as well as before.

(from redmine: written on 2013-08-02)

By Côme Chilliet on 2017-09-02T15:02:07 (imported from GitLab)

Cleaned a bit select classes. They should also be moved to a generic folder as they have not much to do with groups.

(from redmine: written on 2013-08-12)

By Côme Chilliet on 2017-09-02T15:02:08 (imported from GitLab)

Hello,

yes where do you recommend to put them ?

Cheers

(from redmine: written on 2013-08-12)

By bmortier on 2017-09-02T15:02:08 (imported from GitLab)

(for both 1.1 and 1.0.8)

(from redmine: written on 2013-12-11)

By Côme Chilliet on 2017-09-02T15:02:08 (imported from GitLab)

Hello,

commited into 1.0.8 and 1.1

Cheers

(from redmine: written on 2013-12-11)

By bmortier on 2017-09-02T15:02:08 (imported from GitLab)

hello

commited to 1.1, conflicts in 1.0.8

cheers

(from redmine: written on 2013-12-11)

By bmortier on 2017-09-02T15:02:08 (imported from GitLab)

Hello,

the conflict is in the attached file

Cheers

(from redmine: written on 2013-12-11)

By bmortier on 2017-09-02T15:02:09 (imported from GitLab)

Hello,

applied to 1.0.8

Cheers

(from redmine: written on 2013-12-12)

By bmortier on 2017-09-02T15:02:09 (imported from GitLab)

Hello,

commited to 1.0.8 and 1.1

Cheers

(from redmine: written on 2013-12-17)

By bmortier on 2017-09-02T15:02:09 (imported from GitLab)

Hello,

commited on 1.0.8 and 1.1

Cheers

(from redmine: written on 2013-12-18)

By bmortier on 2017-09-02T15:02:09 (imported from GitLab)

This is for 1.0.8

(from redmine: written on 2013-12-19)

By Côme Chilliet on 2017-09-02T15:02:09 (imported from GitLab)

This is for both 1.0.8 and 1.1

(from redmine: written on 2013-12-19)

By Côme Chilliet on 2017-09-02T15:02:10 (imported from GitLab)

Côme BERNIGAUD wrote:

This is for 1.0.8

applied to 1.0.8

Cheers

(from redmine: written on 2013-12-19)

By bmortier on 2017-09-02T15:02:10 (imported from GitLab)

Côme BERNIGAUD wrote:

This is for both 1.0.8 and 1.1

Applied to 1.0.8 and 1.1

Cheers

(from redmine: written on 2013-12-19)

By bmortier on 2017-09-02T15:02:10 (imported from GitLab)

Close issue

(from redmine: written on 2015-05-05)

By Côme Chilliet on 2017-09-02T15:02:10 (imported from GitLab)

closed

By Côme Chilliet on 2017-09-02T15:02:10 (imported from GitLab)

added Fixed label

By bmortier on 2018-10-05T15:24:11 (imported from GitLab)