Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory fusiondirectory
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectoryfusiondirectory
  • Issues
  • #2417
Closed
Open
Issue created May 16, 2013 by bmortier@bmortierMaintainer

CodeSniffer should forbid PHP4 constructor names

We should add this sniff to our ruleset: https://bitbucket.org/xjonc/php-code-sniffer/src/e58f998454c3/CodeSniffer/Standards/Generic/Sniffs/NamingConventions/ConstructorNameSniff.php

It allows to ensure __construct method name is used instead of the classname. That avoid errors, for instance when renaming a class, or making it inheritate simplePlugin instead of plugin.

(from redmine: issue id 2417, created on 2013-05-16, closed on 2013-05-17)

  • Changesets:
    • Revision bd07a8f6 by Côme Chilliet on 2013-05-17T20:18:27.000Z:
Fixes: #2417 CodeSniffer should forbid PHP4 constructor names
  • Revision 2472167f by Côme Chilliet on 2013-05-17T20:18:48.000Z:
Fixes: #2417 CodeSniffer should forbid PHP4 constructor names
  • Custom Fields:
    • Bug in version: 1.0.5
  • Uploads:
    • 0001-Fixes-2417-CodeSniffer-should-forbid-PHP4-constructo.patch
Assignee
Assign to
Time tracking